etherpad-lite: init at 2.2.6 #353814
Open
etherpad-lite: init at 2.2.6 #353814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
|
Result of 1 package built:
|
|
the package builds fine. i seem to also get a run-time error tho about the db, for which it similarly defaults to trying to write to the nix store: could you maybe update your instructions to incorporate that one as well? (i kinda wish it at least had a working |
You need to change the database path in |
Hm. Does it not create the dirty/sqlite db files by themselves, if they do not yet exist?Your package seems fine, I guess I'm just not so familiar with this software. |
|
@KiaraGrouwstra In your log you see the following error: |
|
I plan to contribute a NixOS module later, to help users setup Etherpad on NixOS. I agree with the fact that Etherpad doesn't have an intuitive command line interface. |
KiaraGrouwstra
approved these changes
Nov 14, 2024
| runHook postBuild | ||
| ''; | ||
|
|
||
| # Upstream scripts uses `pnpm run prod` which is equivalent to |
There was a problem hiding this comment.
How hard would it be to patch that?
There was a problem hiding this comment.
What do you mean by 'that'? Should I change makeWrapper arguments to use pnpm in $out?
wegank
added
the
12.approvals: 1
wegank
removed
the
12.approvals: 1
gepbird
reviewed
Jan 15, 2025
| fetchFromGitHub, | ||
| fetchpatch, | ||
| gitUpdater, | ||
| pnpm, |
There was a problem hiding this comment.
Most likely you need to change pnpm to pnpm_9. Since #371832, it points to pnpm_10 instead of pnpm_9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #117608
When starting
etherpad-lite, you need to provide some arguments:--settingswith an absolute path to settings.json--credentialswith an absolute path tocredentials.json(which will be created),--sessionkeywith an absolute path toSESSIONKEY.txt(which will be created).else etherpad-lite will try to write into the Nix store and fail.
settings.jsonalso needs to reference a database outside of the nix store.Note: we will need to contribute an option upstream later for plugins support, as Etherpad hardcodes the path to
<etherpad_root>/var/installed_plugins.json: https://github.com/ether/etherpad-lite/blob/056e777539dc9b5ef7db965740965b0f49ac388e/bin/plugins.ts#L68Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.