Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.bids-validator: fix build #353943

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

wegank
Copy link
Member

@wegank wegank commented Nov 6, 2024

ZHF: #352882

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Nov 6, 2024
@ofborg ofborg bot requested a review from bcdarwin November 7, 2024 03:13
@SFrijters
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353943


x86_64-linux

❌ 4 packages failed to build:
  • python311Packages.heudiconv
  • python311Packages.heudiconv.dist
  • python312Packages.heudiconv
  • python312Packages.heudiconv.dist
✅ 24 packages built:
  • python311Packages.bids-validator
  • python311Packages.bids-validator.dist
  • python311Packages.bidsschematools
  • python311Packages.bidsschematools.dist
  • python311Packages.nipype
  • python311Packages.nipype.dist
  • python311Packages.niworkflows
  • python311Packages.niworkflows.dist
  • python311Packages.pybids
  • python311Packages.pybids.dist
  • python311Packages.templateflow
  • python311Packages.templateflow.dist
  • python312Packages.bids-validator
  • python312Packages.bids-validator.dist
  • python312Packages.bidsschematools
  • python312Packages.bidsschematools.dist
  • python312Packages.nipype
  • python312Packages.nipype.dist
  • python312Packages.niworkflows
  • python312Packages.niworkflows.dist
  • python312Packages.pybids
  • python312Packages.pybids.dist
  • python312Packages.templateflow
  • python312Packages.templateflow.dist

@wegank wegank marked this pull request as ready for review November 10, 2024 03:04
@nix-owners nix-owners bot requested a review from natsukium November 10, 2024 03:06
@zi3m5f
Copy link
Contributor

zi3m5f commented Nov 11, 2024

The build failure of heudiconv seems to be caused by datalad:

┃ │  ├─ ⚠ python3.12-datalad-1.1.3 failed with exit code 1 after ⏱ 12m20s in pytestCheckPhase
┃ ├─ ⏸ python3.12-heudiconv-1.2.0

I fixed datalad in #355222 (disabled a test).

@wegank
Copy link
Member Author

wegank commented Nov 12, 2024

@ofborg build python312Packages.heudiconv python312Packages.heudiconv.passthru.tests

@wegank wegank merged commit 460abae into NixOS:master Nov 13, 2024
37 of 39 checks passed
@wegank wegank deleted the bids-validator-fix branch November 13, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants