Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clickhouse: fix compilation on aarch64-linux #353983

Merged
merged 1 commit into from
Nov 9, 2024
Merged

clickhouse: fix compilation on aarch64-linux #353983

merged 1 commit into from
Nov 9, 2024

Conversation

xanderio
Copy link
Contributor

@xanderio xanderio commented Nov 6, 2024

Workaround for: #353775

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@xanderio xanderio force-pushed the clickhouse-no-armv8 branch from 763819e to defa40d Compare November 6, 2024 10:31
@xanderio xanderio force-pushed the clickhouse-no-armv8 branch from defa40d to 887a74f Compare November 6, 2024 10:33
@xanderio xanderio added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 6, 2024
@ofborg ofborg bot requested a review from mbalatsko November 6, 2024 14:36
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 6, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 6, 2024
@vcunat
Copy link
Member

vcunat commented Nov 9, 2024

Hydra builds also affected on 24.05 now: https://hydra.nixos.org/build/277504634

@JohnRTitor JohnRTitor merged commit 112d505 into NixOS:master Nov 9, 2024
33 of 34 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Nov 9, 2024
Merged
1 task
@xanderio xanderio deleted the clickhouse-no-armv8 branch November 9, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnRTitor JohnRTitor JohnRTitor left review comments

@mbalatsko mbalatsko mbalatsko approved these changes

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xanderio @vcunat @mbalatsko @JohnRTitor @wegank