Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: replace references to --replace for the substitute command #354093

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

djacu
Copy link
Member

@djacu djacu commented Nov 6, 2024

The --replace argument for substitute and substituteInPlace was deprecated in e07a2fa. Updating all references in the nixpkgs manual to use --replace-fail.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The `--replace` argument for `substitute` and `substituteInPlace` was
deprecated in e07a2fa. Updating all
references in the nixpkgs manual to use `--replace-fail`.
@djacu djacu requested a review from DanielSidhion November 6, 2024 22:15
@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Nov 6, 2024
@fabianhjr fabianhjr merged commit 3f45fa2 into NixOS:master Nov 7, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants