Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mangojuice: init at 0.7.8 #354321

Merged
merged 1 commit into from
Dec 9, 2024
Merged

mangojuice: init at 0.7.8 #354321

merged 1 commit into from
Dec 9, 2024

Conversation

pluiedev
Copy link
Contributor

@pluiedev pluiedev commented Nov 7, 2024

Fixes #354175

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 8, 2024
@KiaraGrouwstra
Copy link
Contributor

Result of nixpkgs-review pr 354321 run on x86_64-linux 1

1 package built:
  • mangojuice

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2109

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 29, 2024
pkgs/by-name/ma/mangojuice/package.nix Show resolved Hide resolved
pkgs/by-name/ma/mangojuice/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ma/mangojuice/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ma/mangojuice/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ma/mangojuice/package.nix Show resolved Hide resolved
@pluiedev pluiedev requested a review from getchoo December 9, 2024 07:59
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 9, 2024
@getchoo
Copy link
Member

getchoo commented Dec 9, 2024

@ofborg build mangojuice mangojuice.passthru.tests

@getchoo getchoo added 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically labels Dec 9, 2024
@getchoo getchoo merged commit 1331eda into NixOS:master Dec 9, 2024
23 of 26 checks passed
nix-backports bot pushed a commit that referenced this pull request Dec 9, 2024
(cherry picked from commit 1331eda)
@nix-backports
Copy link

nix-backports bot commented Dec 9, 2024

Successfully created backport PR for release-24.11:

getchoo pushed a commit that referenced this pull request Dec 9, 2024
mangojuice: init at 0.7.8 (#354321)

(cherry picked from commit 1331eda)

Co-authored-by: Leah Amelia Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: MangoJuice
6 participants