devmode: make reusable #354556
Merged
devmode: make reusable #354556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
GetPsyched
reviewed
Nov 8, 2024
the `devmode` helper made for the Nixpkgs/NixOS manual was exposed wrapped
in `mkShell`, which made it impossible to reuse.
this change strips that wrapper and reproduces it at the call site.
now one can use `devmode` from anywhere Nixpkgs is available:
devmode = pkgs.callPackage "${pkgs.path}/pkgs/tools/nix/web-devmode.nix" {
buildArgs = toString ./.;
open = "/index.html";
};
now one can use `devmode` from anywhere Nixpkgs is available:
devmode = pkgs.devmode.override {
buildArgs = toString ./.;
open = "/index.html";
};
fricklerhandwerk
force-pushed
the
refactor-devmode
branch
from
f0746a6 to
0ca0659
Compare
ofborg
bot
added
8.has: package (new)
mightyiam
approved these changes
Nov 12, 2024
| error_page = writeShellScriptBin "error_page" '' | ||
| echo "<!DOCTYPE html> | ||
| error-page = writeShellScriptBin "error-page" '' | ||
| cat << EOF |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
devmodehelper made for the Nixpkgs/NixOS manual was exposed wrappedin
mkShell, which made it impossible to reuse.this change strips that wrapper and reproduces it at the call site.
now one can use
devmodefrom anywhere Nixpkgs is available:Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell --run devmodeindocandnixos/doc/manualnix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.