WIP: archivebox: 0.7.2 -> 0.8.6rc3; nixos/archivebox: init #354836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrox0
force-pushed
the
archivebox-0.8.0
branch
from
a71c1d2 to
aa68713
Compare
getchoo
requested changes
Nov 9, 2024
pyrox0
force-pushed
the
archivebox-0.8.0
branch
2 times, most recently
from
e95d07b to
ca907af
Compare
mweinelt
reviewed
Nov 9, 2024
pyrox0
force-pushed
the
archivebox-0.8.0
branch
2 times, most recently
from
35dab76 to
f47e672
Compare
ofborg
bot
requested review from
SuperSandro2000,
JohnAZoidberg,
viraptor and
siraben
pyrox0
force-pushed
the
archivebox-0.8.0
branch
2 times, most recently
from
be80485 to
8315cfc
Compare
github-actions
bot
added
6.topic: nixos
pyrox0
force-pushed
the
archivebox-0.8.0
branch
from
8315cfc to
6cc8ebf
Compare
pyrox0
changed the title
pyrox0
force-pushed
the
archivebox-0.8.0
branch
2 times, most recently
from
c4870c0 to
c47fbfb
Compare
viraptor
reviewed
Nov 15, 2024
| substituteInPlace manage_django_project/tests/test_command_coverage.py \ | ||
| manage_django_project/tests/test_command_tox.py \ | ||
| manage_django_project/tests/test_command_update_test_snapshot_files.py \ | ||
| --replace-fail '.../bin/coverage' '${coverage}/bin/coverage' |
There was a problem hiding this comment.
Could be better to patch https://github.com/jedie/manage_django_project/blob/a07806a0304c0106f8378fad69b91de5c52f0b16/manage_django_project/tests/command_test_utils.py#L13 instead to strip the nix store path, so we don't have to patch all the separate tests.
wegank
added
the
2.status: merge conflict
pyrox0
changed the title
These depend on each other, so both are added here to ensure evaluation never breaks. python3Packages.django-tools: init at 0.56.2 python3Packages.manage-django-project: init at 0.8.0
pyrox0
force-pushed
the
archivebox-0.8.0
branch
from
93d5e06 to
d868e31
Compare
pyrox0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is currently in draft state to get feedback about it. This is not ready to merge.
The plan is to merge this for the NixOS 25.05 release at the earliest, this is a breaking change so it will not be backported to 24.11.
See the upstream changelogs for all the changes between the current 0.7.2 and today:
Things done
Tasks to finish before merge(vague order, not required in this order):
Folks building/testing this on non-
x86_64-linuxmachines would be appreciated, I only have access tox86_64-linuxmyself.@mweinelt!)nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.