Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bashly: 1.1.10 -> 1.2.6 #355134

Merged
merged 1 commit into from
Nov 11, 2024
Merged

bashly: 1.1.10 -> 1.2.6 #355134

merged 1 commit into from
Nov 11, 2024

Conversation

zendo
Copy link
Contributor

@zendo zendo commented Nov 11, 2024 •
edited
Loading

https://github.com/DannyBen/bashly/releases

  • switch to bundlerApp
  • add updateScript
  • update

It will be easy to update with one single command:
nix-shell maintainers/scripts/update.nix --argstr package bashly

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from drupol November 11, 2024 17:51
@drupol
Copy link
Contributor

drupol commented Nov 11, 2024 •
edited
Loading

Related to #351833

@drupol
Copy link
Contributor

drupol commented Nov 11, 2024

@ofborg build bashly

@drupol
Copy link
Contributor

drupol commented Nov 11, 2024

thank you !!!!

@drupol drupol merged commit 10ebb62 into NixOS:master Nov 11, 2024
53 of 56 checks passed
@drupol drupol mentioned this pull request Nov 11, 2024
Open
63 tasks
@zendo zendo deleted the upd/bashly branch November 12, 2024 02:44
@drupol drupol added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.05 labels Nov 12, 2024
@github-actions github-actions bot mentioned this pull request Nov 12, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zendo @drupol