git-worktree-switcher: init at 0.2.4

[jiriks74]

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[jiriks74]

I think that all everything should now work as expected. I'll look into doing tests as that's something I am not familiar with.
But I think that the rest can be reviewed.

[mateusauler]

Awesome! I'm willing to co-maintain the package, if you'd like.

[jiriks74]

Awesome! I'm willing to co-maintain the package, if you'd like.

I'll gladly add you if you're in the maintainers file.

[mateusauler]

I'll add myself and open a PR to your fork.

[jiriks74]

@mateusauler

I didn't find you in the maintainers file.
I can add you if you fork my changes, follow the README for adding maintainers and make a PR. I cannot add you as when you add a GPG signature to a maintainer the commit has to be signed with the key added.

EDIT: The comment appeared right before I sent this one XD. I'll be looking forward to your PR.

[jiriks74]

I just added this package and module to my NixOS config. I had to make a modification to the module though:

diff --git a/modules/nixos/git-worktree-switcher.nix b/modules/nixos/git-worktree-switcher.nix
index f1462ab..490c3a2 100644
--- a/modules/nixos/git-worktree-switcher.nix
+++ b/modules/nixos/git-worktree-switcher.nix
@@ -2,6 +2,7 @@
   config,
   pkgs,
   lib,
+  ...
 }:
 
 let

or I'd get

       error: function 'anonymous lambda' called with unexpected argument 'outputs'
       at /nix/store/qc8rd1yhqd06yjfcnpigkfpnfgmyz2dy-source/modules/nixos/git-worktree-switcher.nix:1:1:
            1| {
             | ^
            2|   config,

So it seems like the missing ... creates an issue with flakes.

---

Is the no ... requirement only for packages or for modules too? (I understood from the docs to avoid it if possible)

I'll be looking through other modules and adding it back if I see ... being commonly used.

[mateusauler]

Whoops, forgot to format the maintainers section in the package file.

[jiriks74]

Whoops, forgot to format the maintainers section in the package file.

I'll take care of it. I'll also add back the ... since I misunderstood the docs and it's kinda needed for the module to work.

[mateusauler]

I'll take care of it.

Thanks.

I'll also add back the ... since I misunderstood the docs and it's kinda needed for the module to work.

I'll test it on my config as well and report any problems other than this one.

[FliegendeWurst]

Please make sure your commit messages follow the guidelines.

[xanderio]

Thanks for your contribution!

The major thing that doesn't look right to me is the fish config part. I've suggested some changes that should make it work. Could you please tests them :)

[mateusauler]

@jiriks74 FYI, I just released v0.2.4.

[jiriks74]

Thanks for the notice @mateusauler.

I've simplified the patch to removing only the update calls, not the functions themselves (less potential breakages in the future) and updated the package to 0.2.4.

[jiriks74]

@mateusauler You can make a pr and add yourself as a mainteiner now.