-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS stuff: part 1 #355629
base: master
Are you sure you want to change the base?
ROS stuff: part 1 #355629
Conversation
Are you planning on adding |
Yes. This PR is based on that overlay.
I'm not familiar with ROS; I'm basing this off of that overlay and will have my roommate (who does use ROS) test this once it's done. If you've got any similar suggestions, they are very welcome! I've taken a look at |
b9a3e4c
to
a0a9195
Compare
I would suggest not bothering with any dependencies of Gazebo classic or ROS Noetic, since they both go EOL in January. |
I'm not sure what version of ROS my roommate needs, so I'll continue packaging everything in the overlay for the time being. UPDATE: My roommate is using kinetic and jazzy, so we're good. I'm not sure which versions of the gazebo build tools correspond to which versions of gazebo yet though, so I'll err on the side of adding too much, and then shrinking as needed. |
cace428
to
5151314
Compare
9a890e2
to
fba721b
Compare
Thanks for working on this, @Pandapip1 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a misssing hash, but othewise this seems to work well on both x86_64-linux and aarch64-darwin
@Pandapip1 : any news about this ? |
This stuff all works last I checked, but nobody's reviewed it. |
Ok, thanks. Could you fix the conflicts ? |
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the latest LTS (Jetty) is available, ref. https://github.com/gazebo-tooling/gazebodistro/blob/master/collection-jetty.yaml for its versions
gz-utils | ||
tinyxml-2 | ||
gts | ||
freeimage # >:( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something with gazebosim/gz-common#590 can be tried ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many failing CI checks for me to consider that yet
See #11713
See #112404
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.