Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS stuff: part 1 #355629

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

ROS stuff: part 1 #355629

wants to merge 16 commits into from

Conversation

Pandapip1
Copy link
Contributor

@Pandapip1 Pandapip1 commented Nov 13, 2024

See #11713

See #112404

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kjeremy
Copy link
Contributor

kjeremy commented Nov 13, 2024

Are you planning on adding rosdep keys for these upstream and coordinating with @lopsided98's https://github.com/lopsided98/nix-ros-overlay?

@Pandapip1
Copy link
Contributor Author

[Are you planning on] coordinating with @lopsided98's https://github.com/lopsided98/nix-ros-overlay?

Yes. This PR is based on that overlay.

Are you planning on adding rosdep keys for these upstream

I'm not familiar with ROS; I'm basing this off of that overlay and will have my roommate (who does use ROS) test this once it's done. If you've got any similar suggestions, they are very welcome!

I've taken a look at rosdep and it does seem reasonable to add keys for nixpkgs. The only potential issue I foresee is that you can't 'install' libraries with nix; I'll see if I can find a way around this.

@Pandapip1 Pandapip1 force-pushed the init-ros branch 7 times, most recently from b9a3e4c to a0a9195 Compare November 14, 2024 01:47
@lopsided98
Copy link
Contributor

I would suggest not bothering with any dependencies of Gazebo classic or ROS Noetic, since they both go EOL in January.

@Pandapip1
Copy link
Contributor Author

Pandapip1 commented Nov 14, 2024

I would suggest not bothering with any dependencies of Gazebo classic or ROS Noetic, since they both go EOL in January.

I'm not sure what version of ROS my roommate needs, so I'll continue packaging everything in the overlay for the time being.

UPDATE: My roommate is using kinetic and jazzy, so we're good. I'm not sure which versions of the gazebo build tools correspond to which versions of gazebo yet though, so I'll err on the side of adding too much, and then shrinking as needed.

@Pandapip1 Pandapip1 force-pushed the init-ros branch 3 times, most recently from cace428 to 5151314 Compare November 14, 2024 05:11
@Pandapip1 Pandapip1 added significant Novel ideas, large API changes, notable refactorings, issues with RFC potential, etc. and removed significant Novel ideas, large API changes, notable refactorings, issues with RFC potential, etc. labels Nov 14, 2024
@Pandapip1 Pandapip1 force-pushed the init-ros branch 2 times, most recently from 9a890e2 to fba721b Compare November 14, 2024 06:09
@nim65s
Copy link
Contributor

nim65s commented Nov 14, 2024

Thanks for working on this, @Pandapip1 !

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 14, 2024
@ofborg ofborg bot requested review from lopsided98 and nim65s November 14, 2024 17:19
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Nov 14, 2024
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a misssing hash, but othewise this seems to work well on both x86_64-linux and aarch64-darwin

pkgs/development/libraries/sdformat/13.nix Show resolved Hide resolved
@Pandapip1 Pandapip1 changed the title [WIP] ROS stuff: init [WIP] ROS stuff: part 1 Nov 24, 2024
@Pandapip1 Pandapip1 marked this pull request as ready for review November 24, 2024 01:14
@Pandapip1 Pandapip1 changed the title [WIP] ROS stuff: part 1 ROS stuff: part 1 Nov 24, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 24, 2024
@ofborg ofborg bot requested a review from nim65s November 24, 2024 19:06
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 31, 2024
@nim65s
Copy link
Contributor

nim65s commented Jan 20, 2025

@Pandapip1 : any news about this ?

@Pandapip1
Copy link
Contributor Author

This stuff all works last I checked, but nobody's reviewed it.

@nim65s
Copy link
Contributor

nim65s commented Jan 20, 2025

Ok, thanks. Could you fix the conflicts ?

@Pandapip1
Copy link
Contributor Author

Rebased.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 20, 2025
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the latest LTS (Jetty) is available, ref. https://github.com/gazebo-tooling/gazebodistro/blob/master/collection-jetty.yaml for its versions

pkgs/development/libraries/gz-cmake/generic.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/gz-common/generic.nix Outdated Show resolved Hide resolved
gz-utils
tinyxml-2
gts
freeimage # >:(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something with gazebosim/gz-common#590 can be tried ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many failing CI checks for me to consider that yet

pkgs/development/libraries/gz-fuel-tools/generic.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/gz-math/generic.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/rosdep/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/rosdistro/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/rospkg/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/vcstools/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/gz-tools/generic.nix Outdated Show resolved Hide resolved
@Pandapip1 Pandapip1 marked this pull request as draft January 27, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants