-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: document commonly used fetchgit flags #355685
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/how-to-use-git-lfs-with-fetchgit/55975/3 |
9142768
to
f16fe7b
Compare
This looks a lot nicer now, thanks! Used with Git. Expects Additionally, the following optional arguments can be given:
Some additional parameters for niche use-cases can be found listed in the function parameters in the declaration of (The example is formatted properly in the actual manual.) |
Some important ones like fetchLFS were missing. See https://discourse.nixos.org/t/how-to-use-git-lfs-with-fetchgit/55975 for a documented instance where this confused a user. This still isn't complete but the remaining ones I felt were rather niche and I am not familiar enough with them to sufficiently document their purpose or usage.
Many parameters added over the past many years were not documented in the manual. People likely simple didn't think to do that, so let's nudge them.
f16fe7b
to
ee97de3
Compare
Backporting because this is an improvement without possibility of any breakage and because it's required for this which should also be backported: #355973 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was the confused user.
This PR would have saved me some hours if it was already merged
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-355685-to-release-24.05 origin/release-24.05
cd .worktree/backport-355685-to-release-24.05
git switch --create backport-355685-to-release-24.05
git cherry-pick -x 1712d71ea76c317a841d0f1308c8236fc43dee0a ee97de3be97fe96c32489c60fa58c164eae2d0c9 |
Successfully created backport PR for |
This seems to break the manual:
|
Probably due to #353513 and can be fixed with diff --git a/doc/redirects.json b/doc/redirects.json
index de640eed00c1..a5a876961848 100644
--- a/doc/redirects.json
+++ b/doc/redirects.json
@@ -1274,6 +1274,9 @@
"fetchgit": [
"index.html#fetchgit"
],
+ "ex-fetchgit-sparseCheckout": [
+ "index.html#ex-fetchgit-sparseCheckout"
+ ],
"fetchfossil": [
"index.html#fetchfossil"
], |
@gador yes, thanks for your patience. @GetPsyched will soon add a helper command so we don't have to do these things manually. |
Thanks for the fix @gador. @fricklerhandwerk @GetPsyched I was not aware that you'd need to do this. You should probably announce the fact that you must do this in the breaking changes for unstable thread. |
Thinking about this again, I don't think it was necessary to backport this for #355973 because this is just docs whereas the actual important thing for backports is the functionality. It doesn't hurt to have this aswell as the docs in 24.11 but I won't backport to 24.05. |
I'm unsure how is this a breaking change. The CI will fail if the redirects aren't correct; it didn't fail for this PR simply because the CI on this PR ran before the redirects system was merged into |
I see. Though I think that's all the more reason to announce this as that'd allow those who might be caught by this caveat to notice it in their PRs. If I knew of this change and that there was the possibility of an integration hazard like this, I'd have checked. |
Some important ones like fetchLFS were missing. See
https://discourse.nixos.org/t/how-to-use-git-lfs-with-fetchgit/55975 for a
documented instance where this confused a user.
This still isn't complete but the remaining ones I felt were rather niche and I
am not familiar enough with the to sufficiently document their purpose or usage.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.