Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngtcp2-gnutls: 1.8.0 -> 1.9.1 #355866

Merged
merged 1 commit into from
Dec 9, 2024
Merged

ngtcp2-gnutls: 1.8.0 -> 1.9.1 #355866

merged 1 commit into from
Dec 9, 2024

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/ngtcp2/ngtcp2/releases.

meta.description for ngtcp2-gnutls is: Effort to implement RFC9000 QUIC protocol

meta.homepage for ngtcp2-gnutls is: https://github.com/ngtcp2/ngtcp2

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done

  • built on NixOS

Caution

A test defined in passthru.tests did not pass.

  • found 1.8.1 with grep in /nix/store/y2qlf541236xnh8pr2k46066d3fmy843-ngtcp2-1.8.1
  • found 1.8.1 in filename of file in /nix/store/y2qlf541236xnh8pr2k46066d3fmy843-ngtcp2-1.8.1
Rebuild report (if merged into master) (click to expand) 
7 total rebuild path(s)

7 package rebuild(s)

First fifty rebuilds by attrpath

knot-dns
knot-resolver
ngtcp2-gnutls
prometheus-knot-exporter
python311Packages.libknot
python312Packages.libknot
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/y2qlf541236xnh8pr2k46066d3fmy843-ngtcp2-1.8.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A ngtcp2-gnutls https://github.com/r-ryantm/nixpkgs/archive/44376ea3106fa2ca35f498a5b566c0cf6ccb4365.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/44376ea3106fa2ca35f498a5b566c0cf6ccb4365#ngtcp2-gnutls

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/y2qlf541236xnh8pr2k46066d3fmy843-ngtcp2-1.8.1
ls -la /nix/store/y2qlf541236xnh8pr2k46066d3fmy843-ngtcp2-1.8.1/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review

x86_64-linux

✅ 13 packages built:
  • knot-dns
  • knot-dns.bin
  • knot-dns.dev
  • knot-resolver
  • knot-resolver.dev
  • ngtcp2-gnutls
  • ngtcp2-gnutls.dev
  • prometheus-knot-exporter
  • prometheus-knot-exporter.dist
  • python311Packages.libknot
  • python311Packages.libknot.dist
  • python312Packages.libknot
  • python312Packages.libknot.dist
Maintainer pings

cc @vcunat for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a 👍 reaction to pull requests you find important.

@vcunat
Copy link
Member

vcunat commented Nov 14, 2024

A test defined in passthru.tests did not pass.

That's knot-dns.tests.kea, at a quick local run. No idea why so far.

@vcunat
Copy link
Member

vcunat commented Nov 14, 2024 

router: must succeed: curl --no-buffer 127.0.0.1:9547 | grep -qE '^kea_dhcp4_addresses_assigned_total.*1.0$'
[...]
router # curl: (23) client returned ERROR on write of 6556 bytes

@ofborg ofborg bot requested a review from vcunat November 14, 2024 20:14
@r-ryantm r-ryantm changed the title ngtcp2-gnutls: 1.8.0 -> 1.8.1 ngtcp2-gnutls: 1.8.0 -> 1.9.1 Dec 9, 2024
@r-ryantm r-ryantm force-pushed the auto-update/ngtcp2-gnutls branch from 44376ea to 2ee0147 Compare December 9, 2024 03:29
@r-ryantm
Copy link
Contributor Author

r-ryantm commented Dec 9, 2024

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/ngtcp2/ngtcp2/releases.

meta.description for ngtcp2-gnutls is: Effort to implement RFC9000 QUIC protocol

meta.homepage for ngtcp2-gnutls is: https://github.com/ngtcp2/ngtcp2

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done

  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.9.1 with grep in /nix/store/fx1rikz8r2qj9rmbjj5pm8i9b5bqzf58-ngtcp2-1.9.1
  • found 1.9.1 in filename of file in /nix/store/fx1rikz8r2qj9rmbjj5pm8i9b5bqzf58-ngtcp2-1.9.1
Rebuild report (if merged into master) (click to expand) 
7 total rebuild path(s)

7 package rebuild(s)

First fifty rebuilds by attrpath

knot-dns
knot-resolver
ngtcp2-gnutls
prometheus-knot-exporter
python311Packages.libknot
python312Packages.libknot
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/fx1rikz8r2qj9rmbjj5pm8i9b5bqzf58-ngtcp2-1.9.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A ngtcp2-gnutls https://github.com/r-ryantm/nixpkgs/archive/2ee01474dac2a13944c1b66d55f41292bba54389.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/2ee01474dac2a13944c1b66d55f41292bba54389#ngtcp2-gnutls

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/fx1rikz8r2qj9rmbjj5pm8i9b5bqzf58-ngtcp2-1.9.1
ls -la /nix/store/fx1rikz8r2qj9rmbjj5pm8i9b5bqzf58-ngtcp2-1.9.1/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review

x86_64-linux

✅ 13 packages built:
  • knot-dns
  • knot-dns.bin
  • knot-dns.dev
  • knot-resolver
  • knot-resolver.dev
  • ngtcp2-gnutls
  • ngtcp2-gnutls.dev
  • prometheus-knot-exporter
  • prometheus-knot-exporter.dist
  • python311Packages.libknot
  • python311Packages.libknot.dist
  • python312Packages.libknot
  • python312Packages.libknot.dist
Maintainer pings

cc @vcunat for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a 👍 reaction to pull requests you find important.

@vcunat
Copy link
Member

vcunat commented Dec 9, 2024

Looks good now. Probably no sense in waiting for ofBorg for such a simple change.

@vcunat vcunat merged commit 45364c3 into NixOS:master Dec 9, 2024
19 of 20 checks passed
@vcunat vcunat added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.11 Backport PR automatically labels Dec 9, 2024
@nix-backports
Copy link

nix-backports bot commented Dec 9, 2024

Successfully created backport PR for release-24.11:

@nix-backports nix-backports bot mentioned this pull request Dec 9, 2024
Merged
1 task
@nix-backports
Copy link

nix-backports bot commented Dec 9, 2024

Git push to origin failed for release-24.11 with exitcode 1

@vcunat vcunat removed the 1.severity: security Issues which raise a security issue, or PRs that fix one label Dec 9, 2024
@vcunat
Copy link
Member

vcunat commented Dec 9, 2024 •
edited
Loading

Rethought the labeling. It seems unlikely that anyone (beyond upstream knot-dns devs) uses functionality affected by this CVE-2024-52811.

@r-ryantm r-ryantm deleted the auto-update/ngtcp2-gnutls branch December 9, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-ryantm @vcunat