nicotine-plus: 3.3.5 -> 3.3.6 #356319
Merged
nicotine-plus: 3.3.5 -> 3.3.6 #356319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
|
Tested the ability to see shares, tested libadwaita functionality, opening a chatroom, looking at profiles and all has seemed to be fine to me. Damnit, emacs... Will try and editorconfig the package, apologies. |
NixOSInfra
added
the
12. first-time contribution
amadaluzia
force-pushed
the
update-nicotine-plus
branch
3 times, most recently
from
743c132 to
bd1b1d5
Compare
ofborg
bot
added
11.by: package-maintainer
amadaluzia
force-pushed
the
update-nicotine-plus
branch
2 times, most recently
from
64704b8 to
5609f56
Compare
amadaluzia
force-pushed
the
update-nicotine-plus
branch
from
5609f56 to
f2f2d01
Compare
pluiedev
approved these changes
Nov 21, 2024
|
Tried squashing them all and it's not going so greatly lol 😅 |
amadaluzia
force-pushed
the
update-nicotine-plus
branch
from
4593775 to
903651e
Compare
|
Squashed all the commits together, I believe this is ready for merging now. |
pluiedev
approved these changes
Nov 21, 2024
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have done some refactoring in the nicotine-plus package to fix libadwaita being an issue, (you may test this with running nicotine-plus with NICOTINE_LIBADWAITA="1") and updated the package from 3.3.5 to 3.3.6.
You may read about changes made in 3.3.6 here: https://nicotine-plus.org/NEWS.html
This introduces a renderer change which may affect some computers.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.