Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove deprecations up until 24.11 (staging part) #356735

Merged

Conversation

wolfgangwalther
Copy link
Contributor

Same as #356732, but with changes causing a few rebuilds.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

23.05 is not supported anymore.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: golang 6.topic: testing Tooling for automated testing of packages and modules labels Nov 17, 2024
@wolfgangwalther wolfgangwalther added the backport staging-24.11 Backport PR automatically label Nov 17, 2024
@katexochen
Copy link
Contributor

Please drop the Go commit, args have already been removed for buildGoModule on staging, and buldGoPackage is removen in total on #349478, so this will only cause merge conflict between staging and master.

Scheduled for removal in 24.11, so let's follow through.

Added in NixOS#291544.
@wolfgangwalther wolfgangwalther force-pushed the remove-deprecations-for-2411-staging branch from 61594f9 to 71306e6 Compare November 17, 2024 16:23
@wolfgangwalther
Copy link
Contributor Author

Please drop the Go commit, args have already been removed for buildGoModule on staging, and buldGoPackage is removen in total on #349478, so this will only cause merge conflict between staging and master.

Thanks for the heads-up. In fact, half of my commit was already gone by rebasing on staging (modules part) - didn't even notice. Dropped!

@emilazy emilazy merged commit ba15591 into NixOS:staging Nov 22, 2024
30 of 31 checks passed
Copy link
Contributor

Successfully created backport PR for staging-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: testing Tooling for automated testing of packages and modules 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ backport staging-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants