knock: init at 0.8 #356740
Open
knock: init at 0.8 #356740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
xanderio
requested changes
Dec 3, 2024
There was a problem hiding this comment.
This patch does quite a bit more than just moving the output destination. You can probably accomplish the same result with substituteInPlace in the postPatch phase.
xanderio
approved these changes
Dec 3, 2024
xanderio
added
the
12.approvals: 1
Aleksanaa
reviewed
Dec 4, 2024
There was a problem hiding this comment.
This may not be accepted as the project lacks activity and it is said to have an unrevealed vulnerability (jvinet/knock#91)
Comment on lines
+30
to
+35
| substituteInPlace Makefile.am \ | ||
| --replace-fail "sbin_PROGRAMS = knockd" "bin_PROGRAMS += knockd" \ | ||
| --replace-fail "dist_sbin_SCRIPTS = src/knock_helper_ipt.sh" "" \ | ||
| --replace-fail "sysconf_DATA = knockd.conf" "" \ | ||
| --replace-fail "dist_doc_DATA = README.md TODO ChangeLog COPYING" "" \ | ||
| --replace-fail "src/knock_helper_ipt.sh" "" |
There was a problem hiding this comment.
Please use patch instead, this looks painful
There was a problem hiding this comment.
(The review above does not say that you should move the complicated parts to substituteInPlace)
There was a problem hiding this comment.
I was thinking about just patching the sbin_PROGAMS part ^^', in this case this should indeed be a patch.
| ''; | ||
|
|
||
| meta = { | ||
| description = "A port-knocking implementation"; |
There was a problem hiding this comment.
Suggested change
| description = "A port-knocking implementation"; | |
| description = "Port-knocking implementation"; | |
| longDescription = '' | |
| This is a port-knocking server/client. Port-knocking is | |
| a method where a server can sniff one of its interfaces | |
| for a special "knock" sequence of port-hits. When | |
| detected, it will run a specified event bound to that port | |
| knock sequence. These port-hits need not be on open | |
| ports, since we use libpcap to sniff the raw interface traffic. | |
| ''; |
| license = lib.licenses.gpl2Plus; | ||
| maintainers = with lib.maintainers; [ theobori ]; | ||
| mainProgram = "knock"; | ||
| platforms = lib.platforms.unix; |
There was a problem hiding this comment.
Suggested change
| platforms = lib.platforms.unix; | |
| platforms = lib.platforms.linux; |
wegank
removed
the
12.approvals: 1
Aleksanaa
added
awaiting_changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A port-knocking implementation.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.