-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matlab: init at R2024b #356831
base: master
Are you sure you want to change the base?
matlab: init at R2024b #356831
Conversation
This looks awesome! |
Unless multi-version support is intended, it should be moved to |
Result of 1 package built:
|
Yes, I have mixed feelings about the multi-versions. I think I might change to a single version and then add an option so the user can override the version downloaded via mpm (this is what mathematica does). Will move to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fetchers and the main package are built assuming that packages from MPM must be fetched together, and Matlab must always be fetched together with other packages. This means the user will always need to re-fetch and rebuild matlab
whenever they want additional software provided by mpm
, such as Simulink.
Could Matlab and related packages like Simulink be packaged separately and made to depend on one another? That could save the user quite some bandwidth.
Good question - having to redownload Matlab all over again was something I experienced when I was trying to install extra products. But mpm automatically installs necessary dependencies and doesn't seem to support incremental downloads so I'm not sure whether it would be possible to avoid redownloading Matlab. The docs for mpm download say "The destination folder must not contain any product files previously downloaded using mpm download. If you specify a folder with existing product files, mpm issues an error." Update: I've checked and it isn't possible to download other software without mpm pulling down Matlab too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you use this for situations where what you have is
- the install ISO + install key
- *.lic files defining license servers that you want to add to the package for system-wide use
Does it expose any programs in bin (matlab, mex, mlint for example, or a script to enter the FHS env)? I don't see where but I'm also not too familiar with buildFHSEnv.
For comparison, I also recently wrote a package which does all of the above. master...2xsaiko:nixpkgs:push-nuzoruwspqxl
Thanks! I'll have a look at your version.
|
d3ccb97
to
bfb9f91
Compare
bfb9f91
to
3fa6cbf
Compare
I've pushed a new version that should allow installation from an ISO. But I can't test it as I don't have access to an ISO... Something like this should work:
The fetcher works nicely too:
|
Should system-wide license servers be configured using a NixOS module (probably more idiomatic) or by overriding the package? |
Having an entry like |
Fixes #56887.
https://www.mathworks.com/products/matlab.html
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.