Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpris-timer: init at 1.1.1 #357092

Merged
merged 1 commit into from
Nov 24, 2024
Merged

mpris-timer: init at 1.1.1 #357092

merged 1 commit into from
Nov 24, 2024

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Nov 18, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey Stunkymonkey force-pushed the mpris-timer branch 2 times, most recently from 82aacf0 to db96548 Compare November 18, 2024 23:14
getchoo
getchoo requested changes Nov 19, 2024
View reviewed changes
pkgs/by-name/mp/mpris-timer/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mp/mpris-timer/package.nix Show resolved Hide resolved
pkgs/by-name/mp/mpris-timer/package.nix Outdated Show resolved Hide resolved
@getchoo getchoo added the backport release-24.11 Backport PR automatically label Nov 19, 2024
@Stunkymonkey Stunkymonkey requested a review from getchoo November 19, 2024 19:52
@Stunkymonkey Stunkymonkey marked this pull request as ready for review November 19, 2024 19:52
@Stunkymonkey
Copy link
Contributor Author

Result of nixpkgs-review pr 357092 run on x86_64-linux 1

1 package built:
  • mpris-timer

@ofborg ofborg bot requested a review from getchoo November 20, 2024 15:11
@Stunkymonkey Stunkymonkey removed the backport release-24.11 Backport PR automatically label Nov 23, 2024
@Stunkymonkey
Copy link
Contributor Author

ping @getchoo

@Aleksanaa Aleksanaa merged commit d657cbc into NixOS:master Nov 24, 2024
33 of 34 checks passed
@getchoo getchoo added the backport release-24.11 Backport PR automatically label Dec 8, 2024
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 8, 2024

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 8, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@getchoo getchoo Awaiting requested review from getchoo

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stunkymonkey @Aleksanaa @getchoo