-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arpack: add ISO C binding and top arpack-mpi attribute #357259
arpack: add ISO C binding and top arpack-mpi attribute #357259
Conversation
ZHF: #352882 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4902 |
6c3ce71
to
8bf2474
Compare
@dotlambda @ttuegel you are indicated as the maintainers of |
Successfully created backport PR for |
https://hydra.nixos.org/build/282505341 and the logs from this PR https://logs.ofborg.org/?key=nixos/nixpkgs.357259&attempt_id=19a3b55b-cc66-414d-a380-8c9dcd0456ad it seems to add single precision api which Accelerate doesn't like so darwin needs to link with openblas. not quite sure what the difference is before / after but looking at the unit tests run it is now running what looks like a single precision unit tests which segfaults where before this change it wasn't (only 6 tests vs 10). we've seen this issue with other things using accelerate and single precision on darwin and the fix is simple. will have a PR up shortly. |
pr for darwin #367594 |
I'd like to propose to enable the ISO C bindings which are used by some programs.
In addition, I'd like to add a top attribute
arpack-mpi
with MPI enabled. This makes it easier to use thearpack
with MPI in flakes.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)@ttuegel @dotlambda
Add a 👍 reaction to pull requests you find important.