Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arpack: add ISO C binding and top arpack-mpi attribute #357259

Merged

Conversation

fedeinthemix
Copy link
Contributor

I'd like to propose to enable the ISO C bindings which are used by some programs.

In addition, I'd like to add a top attribute arpack-mpi with MPI enabled. This makes it easier to use the arpack with MPI in flakes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ttuegel @dotlambda


Add a 👍 reaction to pull requests you find important.

@fedeinthemix
Copy link
Contributor Author

ZHF: #352882

@fedeinthemix fedeinthemix added the backport release-24.11 Backport PR automatically label Nov 27, 2024
@fedeinthemix fedeinthemix changed the title Arpack ng add iso c binding and top arpack-mpi attribute arpack: add ISO C binding and top arpack-mpi attribute Nov 29, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4902

@fedeinthemix
Copy link
Contributor Author

@dotlambda @ttuegel you are indicated as the maintainers of arpack. I'd appreciate your review.

@SuperSandro2000 SuperSandro2000 merged commit 6ccb20a into NixOS:master Dec 22, 2024
36 of 37 checks passed
@nix-backports
Copy link

nix-backports bot commented Dec 22, 2024

Successfully created backport PR for release-24.11:

@paparodeo
Copy link
Contributor

paparodeo commented Dec 23, 2024

https://hydra.nixos.org/build/282505341 and the logs from this PR https://logs.ofborg.org/?key=nixos/nixpkgs.357259&attempt_id=19a3b55b-cc66-414d-a380-8c9dcd0456ad

it seems to add single precision api which Accelerate doesn't like so darwin needs to link with openblas.

not quite sure what the difference is before / after but looking at the unit tests run it is now running what looks like a single precision unit tests which segfaults where before this change it wasn't (only 6 tests vs 10).

we've seen this issue with other things using accelerate and single precision on darwin and the fix is simple. will have a PR up shortly.

@paparodeo
Copy link
Contributor

pr for darwin #367594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants