stirling-pdf: 0.30.1 -> 0.33.1 #357412
Merged
stirling-pdf: 0.30.1 -> 0.33.1 #357412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BonusPlay
approved these changes
Nov 20, 2024
wegank
added
the
12.approvals: 1
TomaSajt
force-pushed
the
stirling-pdf
branch
from
f021fd0 to
6585cbd
Compare
|
Rebased on master, since OfBorg seemed to error out for some reason. |
TomaSajt
removed
the
12.approvals: 1
ofborg
bot
added
11.by: package-maintainer
tomodachi94
reviewed
Nov 25, 2024
There was a problem hiding this comment.
Could you update this from gradle_7 to gradle or gradle_8? Upstream has been using it since v1.0.1, and I'm trying to remove uses of Gradle 7 to make the removal easier when Gradle 9 is inevitably released.
The only reason I ask here is because (Ignore that, I mixed this up with Maven.) This is non-blocking, and I'm happy to make a followup that does the upgrade.deps.json will need to be updated.
tomodachi94
approved these changes
Nov 25, 2024
tomodachi94
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Stirling-Tools/Stirling-PDF/releases
https://github.com/Stirling-Tools/Stirling-PDF/releases/tag/v0.32.0
https://github.com/Stirling-Tools/Stirling-PDF/releases/tag/v0.33.0
https://github.com/Stirling-Tools/Stirling-PDF/releases/tag/v0.33.1
The web app opens as expected
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.