icmptx: init at 0.2-unstable-2023-11-07 #357574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
h7x4
added
8.has: module (new)
ofborg
bot
added
8.has: package (new)
|
I should probably add a release notes entry. |
github-actions
bot
added
8.has: documentation
|
I added a release notes entry. |
wegank
added
the
2.status: merge conflict
|
I resolved the conflict. |
ofborg
bot
removed
the
2.status: merge conflict
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4973 |
| commonOptions = { | ||
| tun = lib.mkOption { | ||
| type = lib.types.str; | ||
| default = "tun0"; |
There was a problem hiding this comment.
Why do we hardcode tun0 and not icmptx0?
There was a problem hiding this comment.
Because the ICMPTX program does not allow changing the interface name and will always use tun0 if available.
There was a problem hiding this comment.
I added this option in case changing the name becomes possible in the future.
|
I fixed the formatting after my previous change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ICMPTX, a program to tunnel IP packets over Ping messages.
https://codeberg.org/jakkarth/icmptx
Also add a NixOS module and a NixOS test.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.