Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs_20: 20.18.0 -> 20.18.1 #357609

Merged
merged 1 commit into from
Nov 20, 2024
Merged

nodejs_20: 20.18.0 -> 20.18.1 #357609

merged 1 commit into from
Nov 20, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 20, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy added backport release-24.11 Backport PR automatically backport staging-24.11 Backport PR automatically backport staging-24.05 and removed backport release-24.11 Backport PR automatically labels Nov 20, 2024
@emilazy
Copy link
Member

emilazy commented Nov 20, 2024

The Zlib error is still there on aarch64-darwin with the patch removed. I assume that the Zlib → V8 → Node cycle hasn’t picked it up yet.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds now, thanks!

@emilazy emilazy merged commit cf99011 into NixOS:staging Nov 20, 2024
10 of 11 checks passed
Copy link
Contributor

Backport failed for staging-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin staging-24.05
git worktree add -d .worktree/backport-357609-to-staging-24.05 origin/staging-24.05
cd .worktree/backport-357609-to-staging-24.05
git switch --create backport-357609-to-staging-24.05
git cherry-pick -x c91f75a39c419da555b55212d0c0a1053caf0cde

Copy link
Contributor

Backport failed for staging-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin staging-24.11
git worktree add -d .worktree/backport-357609-to-staging-24.11 origin/staging-24.11
cd .worktree/backport-357609-to-staging-24.11
git switch --create backport-357609-to-staging-24.11
git cherry-pick -x c91f75a39c419da555b55212d0c0a1053caf0cde

@emilazy
Copy link
Member

emilazy commented Nov 20, 2024

Ah, the LLVM 19 patches are breaking the backport. Could you open a manual backport for 24.11 and then we can get the bot to do 24.05?

@aduh95 aduh95 deleted the nodejs_20 branch November 20, 2024 22:20
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 20, 2024

Backport PR is #357686

@aduh95
Copy link
Contributor Author

aduh95 commented Nov 20, 2024

Other backport PR is #357696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants