vimPlugins.tsc-nvim: init at 2024-08-14

[347Online]

• Adds plugin tsc.nvim

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[347Online]

I ran the commands as outlined in the docs

Is it kosher that it's making so many seemingly unrelated changes? I freshly rebased from upstream before running the update command

TL;DR is it normal to just update the vimPlugins in general when just adding a specific one?

[PerchunPak]

Is it kosher that it's making so many seemingly unrelated changes? I freshly rebased from upstream before running the update command

TL;DR is it normal to just update the vimPlugins in general when just adding a specific one?

A feature for updating individual plugins is WIP, see #336137. For now, please remove all unrelated changes manually

This plugin depends on tsc, it is probably a good idea to patch it like here:

nixpkgs/pkgs/applications/editors/vim/plugins/overrides.nix

Lines 1489 to 1495 in 3745f50

	ranger-nvim = super.ranger-nvim.overrideAttrs {
	patches = [ ./patches/ranger.nvim/fix-paths.patch ];
	postPatch = ''
	substituteInPlace lua/ranger-nvim.lua --replace '@ranger@' ${ranger}/bin/ranger
	'';
	};

Lines, where tsc is used:
https://github.com/dmmulroy/tsc.nvim/blob/82c37ebfe45d30763db6f45b54e18f1e485bb52c/lua/tsc/utils.lua#L19

[347Online]

@PerchunPak Great feedback, thank you. I believe I've addressed the things you've raised, mind giving this another look?

[PerchunPak]

LGTM, just squash all commits into one please

[PerchunPak]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 357769

---

x86_64-linux

✅ 2 packages built:

• vimPlugins.tsc-nvim
• vimPluginsUpdater

---

aarch64-linux

✅ 2 packages built:

• vimPlugins.tsc-nvim
• vimPluginsUpdater

---

x86_64-darwin

✅ 2 packages built:

• vimPlugins.tsc-nvim
• vimPluginsUpdater

---

aarch64-darwin

✅ 2 packages built:

• vimPlugins.tsc-nvim
• vimPluginsUpdater

[teto]

I squashed them from UI. Merging based on @PerchunPak 's approval