Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

element-desktop: 1.11.85 -> 1.11.86 #357842

Merged
merged 1 commit into from
Nov 23, 2024
Merged

element-desktop: 1.11.85 -> 1.11.86 #357842

merged 1 commit into from
Nov 23, 2024

Conversation

teutat3s
Copy link
Member

Changelog: https://github.com/element-hq/element-desktop/releases/tag/v1.11.86

Electron version got bumped to 33 in element-hq/element-desktop@cecea31

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 22, 2024
bjornfor
bjornfor requested changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default electron in release-24.05 is v31 though (not v33). So I think this PR should change electron = electron_32 to electron = electron_33 so that we can safely backport it.

@teutat3s teutat3s force-pushed the element-desktop-1.11.86 branch from 3d9ca4a to 7fd55a9 Compare November 23, 2024 18:51
@teutat3s teutat3s requested a review from bjornfor November 23, 2024 18:51
@bjornfor bjornfor merged commit 6d86d77 into NixOS:master Nov 23, 2024
16 of 17 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Nov 23, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@mguentner mguentner Awaiting requested review from mguentner

@NickCao NickCao Awaiting requested review from NickCao

@dali99 dali99 Awaiting requested review from dali99

@Ralith Ralith Awaiting requested review from Ralith

@sumnerevans sumnerevans Awaiting requested review from sumnerevans

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teutat3s @bjornfor