Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-render-docs: don't validate redirects if none were given #357897

Merged

Conversation

GetPsyched
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GetPsyched
Copy link
Member Author

This fixes downstream build failures as reported in nix-community/home-manager#6110

@GetPsyched GetPsyched force-pushed the fix-ignore-redirects-validation branch from fb1e504 to 212201f Compare November 21, 2024 13:06
@GetPsyched GetPsyched changed the title nixos-render-docs: don't validate redirects if non were given nixos-render-docs: don't validate redirects if none were given Nov 21, 2024
@GetPsyched GetPsyched marked this pull request as draft November 21, 2024 14:23
Copy link
Contributor

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

You told me you manually tested against the Home Manager regression and that this fixes it. Cherry on top here would be a test with an invalid redirects file that is correctly ignored when not specified, but all this looks simple enough that it shouldn't be necessary.

@fricklerhandwerk fricklerhandwerk marked this pull request as ready for review November 21, 2024 19:06
@GetPsyched GetPsyched force-pushed the fix-ignore-redirects-validation branch from 221ab3a to 91c18e4 Compare November 21, 2024 19:10
@fricklerhandwerk fricklerhandwerk merged commit eb2872e into NixOS:master Nov 21, 2024
15 of 16 checks passed
@GetPsyched GetPsyched deleted the fix-ignore-redirects-validation branch November 21, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants