Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urh: 2.9.6 -> 2.9.8; install desktop file #357930

Merged
merged 11 commits into from
Dec 5, 2024
Merged

urh: 2.9.6 -> 2.9.8; install desktop file #357930

merged 11 commits into from
Dec 5, 2024

Conversation

pawsen
Copy link
Contributor

@pawsen pawsen commented Nov 21, 2024

This PR does three things

Things done

  • Built on platform(s)
    • [x ] x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [ x ] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from fpletz November 23, 2024 10:09
@Aleksanaa Aleksanaa changed the title urh: update and install desktop file urh: 2.9.6 -> 2.9.8; install desktop file Dec 4, 2024
@Aleksanaa
Copy link
Member

@ofborg build urh

@Aleksanaa Aleksanaa merged commit 47b5e2e into NixOS:master Dec 5, 2024
18 of 19 checks passed
@Aleksanaa Aleksanaa mentioned this pull request Dec 5, 2024
Closed
@Aleksanaa Aleksanaa added the backport release-24.11 Backport PR automatically label Dec 5, 2024
nixpkgs-ci bot pushed a commit that referenced this pull request Dec 5, 2024
@pawsen @github-actions
urh: 2.9.6 -> 2.9.8; install desktop file (#357930)
a448c4b 
* urh: 2.9.6 -> 2.9.8

* urh: dont double wrap binary with GApps

Fix for previous pull-request #357400. See https://nixos.org/manual/nixpkgs/stable/#ssec-gnome-common-issues-double-wrapped

* urh: install desktop-file

---------

Co-authored-by: Franz Pletz <[email protected]>
Co-authored-by: Aleksana <[email protected]>
(cherry picked from commit 47b5e2e)
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 5, 2024

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 5, 2024
Merged
1 task
Aleksanaa added a commit that referenced this pull request Dec 5, 2024
@Aleksanaa @pawsen
[Backport release-24.11] urh: 2.9.6 -> 2.9.8; install desktop file (#…
e126054 
…362003)

urh: 2.9.6 -> 2.9.8; install desktop file (#357930)

* urh: 2.9.6 -> 2.9.8

* urh: dont double wrap binary with GApps

Fix for previous pull-request #357400. See https://nixos.org/manual/nixpkgs/stable/#ssec-gnome-common-issues-double-wrapped

* urh: install desktop-file

---------

Co-authored-by: Franz Pletz <[email protected]>
Co-authored-by: Aleksana <[email protected]>
(cherry picked from commit 47b5e2e)

Co-authored-by: Paw Møller <[email protected]>
@pawsen pawsen deleted the urh_update_and_desktop_file branch December 5, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa left review comments

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawsen @Aleksanaa @fpletz