Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

longhornctl: init at 1.7.2 #357935

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

longhornctl: init at 1.7.2 #357935

wants to merge 1 commit into from

Conversation

OhMyMndy
Copy link

Adding package for longhornctl

https://github.com/longhorn/cli

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 21, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 21, 2024
pluiedev
pluiedev suggested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Nixpkgs! Here's some suggested changes:

maintainers/maintainer-list.nix
github = "OhMyMndy";
githubId = 227771;
name = "Mandy Schoep";
};
Copy link
Contributor

@pluiedev pluiedev Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in a separate commit titled maintainers: add ohmymndy, before the main commit

pkgs/by-name/lo/longhornctl/package.nix
Comment on lines +1 to +6
{ lib
, buildGoModule
, fetchFromGitHub
, nixosTests
,
}:
Copy link
Contributor

@pluiedev pluiedev Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't format lists like this anymore; please reformat with nixfmt-rfc-style

pkgs/by-name/lo/longhornctl/package.nix
src = fetchFromGitHub {
owner = "longhorn";
repo = "cli";
rev = "v${version}";
Copy link
Contributor

@pluiedev pluiedev Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefixing tags with refs/tags/ is recommended as sometimes it might clash with branch names

Suggested change
rev = "v${version}";
rev = "refs/tags/v${version}";

pkgs/by-name/lo/longhornctl/package.nix
passthru.tests = { inherit (nixosTests) longhornctl; };

meta = {
description = "a CLI (command-line interface) designed to simplify Longhorn manual operations.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See naming conventions at pkgs/README.md

Suggested change
description = "a CLI (command-line interface) designed to simplify Longhorn manual operations.";
description = "CLI designed to simplify Longhorn manual operations";

pkgs/by-name/lo/longhornctl/package.nix
ln -s $out/bin/remote $out/bin/longhornctl
'';

passthru.tests = { inherit (nixosTests) longhornctl; };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a NixOS test added in this PR — did you intend to add one?

pkgs/by-name/lo/longhornctl/package.nix

meta = {
description = "a CLI (command-line interface) designed to simplify Longhorn manual operations.";
downloadPage = "https://github.com/longhorn/cli";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manual says that downloadPage should point to the source to the current version, not just the repository — though I consider this attribute to be somewhat unimportant since it's not specified in the vast majority of packages

pkgs/by-name/lo/longhornctl/package.nix
];

postInstall = ''
ln -s $out/bin/remote $out/bin/longhornctl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move instead of link?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pluiedev pluiedev pluiedev requested changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OhMyMndy @pluiedev @NixOSInfra