glfw3: general improvements #358007
Merged
glfw3: general improvements #358007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMAKE_C_FLAGS did not work previously, as it was defined multiple times. Instead of fixing it, it is much more readable to use NIX_CFLAGS_COMPILE instead of having to escape special characters across Nix, Bash and CMake Signed-off-by: Sefa Eyeoglu <[email protected]>
Including quotes around the library names should make these substitutions stricter. Signed-off-by: Sefa Eyeoglu <[email protected]>
libX11-xcb.so.1 and libXxf86vm.so.1 are dlopen-ed at runtime, but are not linked by the linker. Let's hardcode their library paths into the code. Signed-off-by: Sefa Eyeoglu <[email protected]>
The new apple-sdk pattern doesn't require this anymore. Signed-off-by: Sefa Eyeoglu <[email protected]>
Signed-off-by: Sefa Eyeoglu <[email protected]>
Signed-off-by: Sefa Eyeoglu <[email protected]>
Signed-off-by: Sefa Eyeoglu <[email protected]>
Scrumplex
force-pushed
the
pkgs/glfw/general-improvements
branch
from
cb0a034 to
00b5f4e
Compare
|
ofborg
bot
added
11.by: package-maintainer
|
Nice, thanks. Not sure how this stuff works exactly, but as a reminder, this should be backported, right? Also, on the note of raylib-games, it would be be great to get #357729 merged as well, which updates raylib (and adds a platform argument to allow using SDL), and pretty much rewrites the entire definition, since it was mostly wrong. |
|
The issue(s) fixed by this PR shouldn't be present in 24.11, as #354761 was not backported. I will backport both that and this PR once this is merged. |
|
Regarding my nixpkgs-review result above:
both darwins:
|
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #357732
Closes #356975
Each commit has a description describing its primary change.
The formatting commit is last, to make reviewing easier. The evaluation should not change between
HEADandHEAD^One fairly simple package to test these changes with is
raylib-games. I was able to build and run asteroids both on XWayland and Wayland.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.