google-cloud-sdk: fix gsutil

[terlar]

Fixes a runtime issue with gsutil introduced by #356927. It is an alternative fix to #357355.

This happened due to a more strict Python version constraint that was added to gsutil as part of this new release:
GoogleCloudPlatform/gsutil@c8e2709

gsutil is working on Python 3.12 support:

• https://github.com/GoogleCloudPlatform/gsutil/pulls

gsutil has been running with Python 3.12 for some time and other people indicate that it works "fine".

• Nudge message 3.11 GoogleCloudPlatform/gsutil#1797 (comment)

I added a gsutil check to the install check phase to avoid a similar error happening in the future.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[fabianhjr]

Neutral comment (not against or in favour), there is a preference of not including patches in branch (doing fetchPatch instead of embedding the patch directly in nixpkgs)

As such, I would side with pinning the python version to 3.11 while upstream fixes the versions constraints.

[terlar]

Unfortunately the source code is bundled in a package (google-cloud-sdk) where the location of the file is in a different location than the source repo (gsutil). So I cannot use the fetchPatch.

[marcusramberg]

🎉

[marcusramberg]

Neutral comment (not against or in favour), there is a preference of not including patches in branch (doing fetchPatch instead of embedding the patch directly in nixpkgs)

As such, I would side with pinning the python version to 3.11 while upstream fixes the versions constraints.

Having to install an extra python seems worse for the user compared to this.

[fabianhjr]

extra is only relative to the closure in question, eg a non-python closure that doesn't require any other package that depends on python wouldn't install an extra python (it would have a single python version installed) or closures that otherwise already have python311 would similarly not increase the closure size by one python.

As mentioned, due to being asked to review this PR, I have a preference for the version pinning over embedding a patch in nixpkgs but don't oppose this.

Decision wise it isn't my say at this point regardless.

maintainers = with maintainers; [ iammrinal0 marcusramberg pradyuman stephenmw zimbatm ];

since you are a maintainer feel free to merge (or request me to merge) as is.