Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strawberry: 1.1.3 -> 1.2.2 #358024

Merged
merged 4 commits into from
Dec 4, 2024
Merged

strawberry: 1.1.3 -> 1.2.2 #358024

merged 4 commits into from
Dec 4, 2024

Conversation

staticssleever668
Copy link
Contributor

@staticssleever668 staticssleever668 commented Nov 21, 2024 •
edited
Loading

Closes #343933.
https://raw.githubusercontent.com/jonaski/strawberry/1.2.2/Changelog
Does this need a release note entry?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@staticssleever668 staticssleever668 changed the title Strawberry 1.2.1 strawberry: 1.1.3 -> 1.2.1 Nov 21, 2024
@ofborg ofborg bot requested a review from peterhoeg November 22, 2024 19:46
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 22, 2024
@staticssleever668 staticssleever668 changed the title strawberry: 1.1.3 -> 1.2.1 strawberry: 1.1.3 -> 1.2.2 Nov 23, 2024
@staticssleever668 staticssleever668 mentioned this pull request Nov 26, 2024
Closed
getchoo
getchoo requested changes Nov 28, 2024
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is being formatted, it should be done with nixfmt

Does this need a release note entry?

As you're dropping the Qt 5 version of the package, I would recommend it

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Nov 28, 2024
@staticssleever668
Copy link
Contributor Author

Thanks! Turns out I've been using nixfmt-classic instead of nixfmt-rfc-style. I have also added a release note entry now.

getchoo
getchoo requested changes Nov 30, 2024
View reviewed changes
nixos/doc/manual/release-notes/rl-2505.section.md Outdated Show resolved Hide resolved
pkgs/applications/audio/strawberry/default.nix Outdated Show resolved Hide resolved
@staticssleever668
strawberry: drop strawberry-qt5 in favor of strawberry-qt6
e3a9c19
@staticssleever668
strawberry: 1.1.3 -> 1.2.2
10ce0b2 
VLC backend and Qt 5 build are no longer supported. protobuf is no
longer required. Use packaged kdsingleapplication instead of building it
from submodule.
@staticssleever668
strawberry: drop PCRE dependency
6f860d8 
While strawberry seems to bundle PCRE2 on MacOS and Windows, it doesn't
seem to use it directly.
@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 4, 2024
@Scrumplex
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 358024

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • strawberry (strawberry-qt6)

@Scrumplex Scrumplex merged commit 33be238 into NixOS:master Dec 4, 2024
34 of 35 checks passed
@staticssleever668 staticssleever668 deleted the strawberry-1.2.1 branch December 4, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo approved these changes

@Scrumplex Scrumplex Scrumplex approved these changes

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staticssleever668 @Scrumplex @getchoo