Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vuetorrent: init at 2.18.0 #358030

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

redxtech
Copy link
Contributor

VueTorrent

The sleekest looking WEBUI for qBittorrent made with Vuejs!

VueTorrent is an alternative frontend/webui for qbittorrent.

Homepage/Repo: https://github.com/VueTorrent/VueTorrent
Live Demo: https://vuetorrent.github.io/demo
License: GPL-3.0
Package Request: #296190

Usage:
Within qbittorrent, point the custom webui directory to "${pkgs.vuetorrent}/var/www/vuetorrent".

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@redxtech redxtech force-pushed the init-vuetorrent branch 2 times, most recently from 32ded4e to fea6dfb Compare November 22, 2024 00:37
pkgs/by-name/vu/vuetorrent/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/vu/vuetorrent/package.nix Show resolved Hide resolved
@redxtech
Copy link
Contributor Author

redxtech commented Dec 2, 2024

Comments have been implemented, only one question:

Since the initial PR was download a zip file and packaging the contents, I had the platforms set to platforms.all, but now that it's using buildNpmPackage, I'm not sure what platform to put.

Should I leave it as all? Or is there a subset that buildNpmPackage works with?

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Dec 2, 2024
@steeleduncan
Copy link
Contributor

@redxtech Thanks, I believe buildNpmPackage is fine with all platforms. Ofborg will let you know if there is an issue though!

@redxtech redxtech force-pushed the init-vuetorrent branch 2 times, most recently from 9c670de to 2766958 Compare December 2, 2024 09:54
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 2, 2024
@redxtech
Copy link
Contributor Author

redxtech commented Dec 5, 2024

I'm not sure what's causing the build failure - it built when I ran it, but I didn't try any nixpkgs specific tests. Is there a better way to interpret the build failures? Because I'm not sure what the one in the ofborg-eval check is telling me.

trace: evaluation warning: The deprecated `type.functor.wrapped` attribute of the option `mergedLazyLazy` is accessed, use `type.nestedTypes.elemType` instead.

I haven't touched anything that would use any of those, at least any more than any other buildNpmPackage package would do.

Could this be somehow caused by lack of compatibility with some platform? Should I re-push with a more limited subset of the platforms?

@steeleduncan
Copy link
Contributor

@redxtech I just tried it on linux and it was fine. I think maybe you are right and it is best to restrict to linux

@azuwis
Copy link
Contributor

azuwis commented Dec 11, 2024

@ofborg eval

@ofborg ofborg bot removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 12, 2024
@azuwis
Copy link
Contributor

azuwis commented Dec 13, 2024

I'm not sure what's causing the build failure

I think it was caused by something in master branch, I believe ofborg will eval against the merged code with this PR and current master.

Ofborg-evail succeed after another try.

I think maybe you are right and it is best to restrict to linux

Since qbittorrent and qbittorrent-nox are also available on darwin, I think we should also make vuetorrent available on darwin too.

@steeleduncan
Copy link
Contributor

Since qbittorrent and qbittorrent-nox are also available on darwin, I think we should also make vuetorrent available on darwin too.

Agreed, was confused by the build errors, but as you say they seem to be gone now!

Copy link
Contributor

@ambroisie ambroisie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, can be merged without it.

pkgs/by-name/vu/vuetorrent/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/vu/vuetorrent/package.nix Outdated Show resolved Hide resolved
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 15, 2024
@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 358030


x86_64-linux

✅ 1 package built:
  • vuetorrent

x86_64-darwin

✅ 1 package built:
  • vuetorrent

aarch64-darwin

✅ 1 package built:
  • vuetorrent

@wolfgangwalther wolfgangwalther merged commit 9642691 into NixOS:master Dec 17, 2024
23 of 24 checks passed
@redxtech redxtech deleted the init-vuetorrent branch December 17, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants