-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vuetorrent: init at 2.18.0 #358030
vuetorrent: init at 2.18.0 #358030
Conversation
32ded4e
to
fea6dfb
Compare
fea6dfb
to
12a69f2
Compare
Comments have been implemented, only one question: Since the initial PR was download a zip file and packaging the contents, I had the platforms set to Should I leave it as |
@redxtech Thanks, I believe |
9c670de
to
2766958
Compare
I'm not sure what's causing the build failure - it built when I ran it, but I didn't try any
I haven't touched anything that would use any of those, at least any more than any other Could this be somehow caused by lack of compatibility with some platform? Should I re-push with a more limited subset of the platforms? |
@redxtech I just tried it on linux and it was fine. I think maybe you are right and it is best to restrict to linux |
@ofborg eval |
I think it was caused by something in master branch, I believe ofborg will eval against the merged code with this PR and current master. Ofborg-evail succeed after another try.
Since qbittorrent and qbittorrent-nox are also available on darwin, I think we should also make vuetorrent available on darwin too. |
Agreed, was confused by the build errors, but as you say they seem to be gone now! |
2766958
to
79bb54b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, can be merged without it.
79bb54b
to
cfb5f0a
Compare
cfb5f0a
to
5021abb
Compare
|
VueTorrent
VueTorrent is an alternative frontend/webui for qbittorrent.
Homepage/Repo: https://github.com/VueTorrent/VueTorrent
Live Demo: https://vuetorrent.github.io/demo
License: GPL-3.0
Package Request: #296190
Usage:
Within qbittorrent, point the custom webui directory to
"${pkgs.vuetorrent}/var/www/vuetorrent"
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.