nixos/containers: new registries.settings option, deprecate others #358180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those options mapped to the deprecated V1 format, and didn't allow using the newer format.
If any of the older options are used, a warning is displayed, and the generated
registries.conf
file follows the old V1 format.For more information about the new format, see https://github.com/containers/image/blob/main/docs/containers-registries.conf.5.md
Tested by building the
/etc/containers/registries.conf
file, and checked that I could match both the old and the newer format.Examine the first commit to ignore formatting changes.
cc @NixOS/podman
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.