-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
programs/nh: allow flake uris to be set #358462
Conversation
d43784e
to
f5befe4
Compare
nixos/modules/programs/nh.nix
Outdated
default = null; | ||
description = '' | ||
The path that will be used for the `FLAKE` environment variable. | ||
Any type of flake URI or a path that will be used for the `FLAKE` environment variable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should provide an example here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoms config should I add, or build up an crafted dummy? I was also thinking about that as the Auto-Upgrade provides one, but I didn't want to copy the example nor I wanted to artificially promote my own repos. I mean if all a fine with that, I can do so.
Or do we have any other reasonable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JohnRTitor i rephrased the description to include examples how a flake reference that can be passed looks like. As i wanted to provide an example for both i opted against using the example
field. Let me please know if i should fill that with one of the options.
I used crafted dummy paths.
f5befe4
to
2f0c1ca
Compare
@Shawn8901 In any case, NH 4.0 will support any installable (-f, --expr, etc) and I want to support multiple env variables. So we will probably have to rework the module in any case. |
Honestly i am not sure if i misunderstand the intention of the comment (or am just super salty at the time reading the response). Unless there is a planned release date for that reworked 4.0 version within the next days, wouldn't it be more okayish to just improve the UX on the old state? But it sounds for me, that we are preferring to wait for some rework in the future. But i am fine in not doing it and just pick that change to my own fork until there is some rework available. |
I already approved the PR, just wanted to add that remark |
I came here to merge this you know. There was no need to close this PR. |
Ran into this issue just now. Can we re-open this? Or shall I open a new MR? |
Reopening this isn't possible as the OP deleted their branch, just cherry-pick the commits |
Feel free to open as a new PR |
This allows a configuration like
which lets the user use nh module even when the flake is not available locally (nh itself supports that anyways already).
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.