Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/labeler.yml: add more paths to Java #358523

Merged

Conversation

tomodachi94
Copy link
Member

All of these are in the Java team's scope, so
we should add them to the Java label.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tomodachi94 tomodachi94 added the 6.topic: java Including JDK, tooling, other languages, other VMs label Nov 23, 2024
@tomodachi94 tomodachi94 requested a review from a team November 23, 2024 18:07
@github-actions github-actions bot added 6.topic: policy discussion 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions and removed 6.topic: java Including JDK, tooling, other languages, other VMs labels Nov 23, 2024
.github/labeler.yml Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
@tomodachi94 tomodachi94 force-pushed the enhance/labeler.yml/more-java-paths branch from 83dfe84 to e2f1f30 Compare November 23, 2024 18:19
All of these are in the Java team's scope, so
we should add them to the Java label.
@tomodachi94 tomodachi94 force-pushed the enhance/labeler.yml/more-java-paths branch from e2f1f30 to 2342cc1 Compare November 23, 2024 18:33
@tomodachi94
Copy link
Member Author

Good catches 🙂 These rules were added in #354060, so they weren't super comprehensive.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 24, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 24, 2024
@tomodachi94 tomodachi94 merged commit df24ba5 into NixOS:master Nov 26, 2024
32 checks passed
@tomodachi94 tomodachi94 deleted the enhance/labeler.yml/more-java-paths branch November 26, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants