Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers: add wyzdwdz #358537

Closed
wants to merge 2 commits into from
Closed

maintainers: add wyzdwdz #358537

wants to merge 2 commits into from

Conversation

wyzdwdz
Copy link

@wyzdwdz wyzdwdz commented Nov 23, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 23, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 23, 2024
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution, however, before merging this PR I would like to know a bit more the motivation behind this PR.

Do you have any new open PR where you would like to be maintainer? What's the reason for adding you there?

@wyzdwdz
Copy link
Author

wyzdwdz commented Nov 23, 2024

Thanks for your first contribution, however, before merging this PR I would like to know a bit more the motivation behind this PR.

Do you have any new open PR where you would like to be maintainer? What's the reason for adding you there?

https://github.com/wyzdwdz/nur-pkgs/blob/master/pkgs/spl-token-cli/default.nix

For now I've just packaged this program in NUR. I'm also planning to package all these main programs in SPL (https://github.com/solana-labs/solana-program-library)

@wyzdwdz
Copy link
Author

wyzdwdz commented Nov 23, 2024

Is NUR maintainer also included in this maintainer list? or just the offical nixpkgs? Well because my package is not fully tested, I just wanna leave it in NUR for a while before pull onto this nixpkgs.

@drupol
Copy link
Contributor

drupol commented Nov 23, 2024

In that case, it's maybe better if you submit this with your future PR, this will be less confusing for maintainers.

@wyzdwdz
Copy link
Author

wyzdwdz commented Nov 23, 2024

Okay then, I'm going to leave this for next PR. Thank you for your help.

@wyzdwdz wyzdwdz closed this Nov 23, 2024
@drupol
Copy link
Contributor

drupol commented Nov 23, 2024

Thank you for your comprehension. Feel free to add yourself back in a PR with some more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants