maven.buildMaven: drop

[tomodachi94]

This was discouraged in #240553

Nobody is using it in-tree; the upstream repository provides the same builder in an output of its flake, for out-of-tree consumers: https://github.com/fzakaria/mvn2nix

Closes #11546

I'm not a fan of removing the entries from doc/redirects.json; I would love to redirect the anchors to the related changelog entry, but I'm not sure that's possible.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[tomodachi94]

Result of nixpkgs-review pr 358562 run on aarch64-linux 1

1 package blacklisted:

• nixos-install-tools

1 package built:

• nixpkgs-manual

[fricklerhandwerk]

Concerning the redirects, IIUC there's a place for parking deprecated attribute paths. Maintainers deprecate library functions and packages now and then, this should be similar, right?

If not, it should be possible to create an anchor on the release note entry (not sure though, haven't tried that yet). This situation is exactly what the redirect guards are made for, and I strongly recommend using them.

[tomodachi94]

Concerning the redirects, IIUC there's a place for parking deprecated attribute paths. Maintainers deprecate library functions and packages now and then, this should be similar, right?

Yes, that seems logical. @GetPsyched (author of PR adding the redirects stuff), do you know how we could do this?

If not, it should be possible to create an anchor on the release note entry

Definitely possible, we add anchors to list items all the time in the Nixpkgs manual:

- []{#somewhere-over-the-rainbow} Somewhere over the rainbow, way up high...

I'm not sure redirects.json supports redirecting from the Nixpkgs manual to the NixOS manual (where the release notes live).

[fricklerhandwerk]

That all release notes live in NixOS is a really unfortunate layer violation... The redirects system currently only supports relative paths, but this can be fixed quickly.

[fzakaria]

isn't this part not related to mvn2nix ?

[fzakaria]

I think you removed too much;
There is https://github.com/fzakaria/mvn2nix and there is https://github.com/NixOS/mvn2nix-maven-plugin (actually different solutions but with same name 🤦 )
It's also archived /shrug

(My attempt at mvn2nix is kind of a half-baked also; I ended up fighting so much enterprise pathalogical cases that it became unsurmountable as a side-effort)

Either way PR looks ok.

[fzakaria]

I think I wrote this explanation section; I think it's all pretty good advice still on learning lessons on how to integrate java with Nix.

Maybe we can retitle these sections and just remove the top.