Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{gst_all_1.*,python3Packages.gst-python}: 1.24.7 -> 1.24.9 #358564

Closed
wants to merge 11 commits into from
Closed

{gst_all_1.*,python3Packages.gst-python}: 1.24.7 -> 1.24.9 #358564

wants to merge 11 commits into from

Conversation

jwillikers
Copy link
Contributor

https://gstreamer.freedesktop.org/releases/1.24/#1.24.9
https://gstreamer.freedesktop.org/releases/1.24/#1.24.8

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy
Copy link
Member

emilazy commented Nov 25, 2024

I think you need to update the rest of the gst_all_1.* packages; see e.g. #339147, #313707.

@jwillikers jwillikers changed the title gstreamer: 1.24.7 -> 1.24.9 {gst_all_1.*,python3Packages.gst-python}: 1.24.7 -> 1.24.9 Nov 25, 2024
@jwillikers
Copy link
Contributor Author

I think you need to update the rest of the gst_all_1.* packages; see e.g. #339147, #313707.

Will do, thank you for those links!

@jwillikers
Copy link
Contributor Author

@emilazy Which ones did miss in particular? Comparing, it looks like I got pretty much the same ones in those previous PRs.

@emilazy
Copy link
Member

emilazy commented Nov 25, 2024

Oh, I’m sorry, I just reacted to the commit message before checking the diff :) We generally prefer one package bump per commit, nix-update --commit -f . should help automate that when there’s a bunch of them like here.

@ofborg ofborg bot requested a review from wineee November 26, 2024 09:26
@wineee
Copy link
Member

wineee commented Nov 28, 2024

Build failed on ofborg

shrinking RPATHs of ELF executables and libraries in /nix/store/7y70fm3fxk93jw7gq3vis25rhs2zdy8v-gst-devtools-1.24.9-dev
checking for references to /build/ in /nix/store/7y70fm3fxk93jw7gq3vis25rhs2zdy8v-gst-devtools-1.24.9-dev...
patching script interpreter paths in /nix/store/7y70fm3fxk93jw7gq3vis25rhs2zdy8v-gst-devtools-1.24.9-dev
stripping (with command strip and flags -S -p) in  /nix/store/7y70fm3fxk93jw7gq3vis25rhs2zdy8v-gst-devtools-1.24.9-dev/lib
building '/nix/store/y9d0mwwbidl2sf7nxmwn9fx2mvyars2f-gst-editing-services-1.24.9.drv'...
Running phase: unpackPhase
unpacking source archive /nix/store/2zf2rpik354s4k1gpqq923jpjw1lxvkq-gst-editing-services-1.24.9.tar.xz
source root is gst-editing-services-1.24.9
setting SOURCE_DATE_EPOCH to timestamp 1730320523 of file gst-editing-services-1.24.9/ChangeLog
Running phase: patchPhase
patching script interpreter paths in scripts/extract-release-date-from-doap-file.py
scripts/extract-release-date-from-doap-file.py: interpreter directive changed from "#!/usr/bin/env python3" to "/nix/store/qjjf7zs5n7sfhqvz52q511b2gxhxwi4w-python3-3.12.7/bin/python3"
substituteStream() in derivation gst-editing-services-1.24.9: ERROR: pattern GstFrameCompositionApi doesn't match anything in file 'ges/ges-frame-composition-meta.c'
error: builder for '/nix/store/y9d0mwwbidl2sf7nxmwn9fx2mvyars2f-gst-editing-services-1.24.9.drv' failed with exit code 1;
       last 8 log lines:
       > Running phase: unpackPhase
       > unpacking source archive /nix/store/2zf2rpik354s4k1gpqq923jpjw1lxvkq-gst-editing-services-1.24.9.tar.xz
       > source root is gst-editing-services-1.24.9
       > setting SOURCE_DATE_EPOCH to timestamp 1730320523 of file gst-editing-services-1.24.9/ChangeLog
       > Running phase: patchPhase
       > patching script interpreter paths in scripts/extract-release-date-from-doap-file.py
       > scripts/extract-release-date-from-doap-file.py: interpreter directive changed from "#!/usr/bin/env python3" to "/nix/store/qjjf7zs5n7sfhqvz52q511b2gxhxwi4w-python3-3.12.7/bin/python3"
       > substituteStream() in derivation gst-editing-services-1.24.9: ERROR: pattern GstFrameCompositionApi doesn't match anything in file 'ges/ges-frame-composition-meta.c'
       For full logs, run 'nix-store -l /nix/store/y9d0mwwbidl2sf7nxmwn9fx2mvyars2f-gst-editing-services-1.24.9.drv'.

@LeSuisse
Copy link
Contributor

Could you please bump to the recently released 1.24.10 https://gstreamer.freedesktop.org/releases/1.24/#1.24.10 ?

It fixes an bunch of security issues:
CVE-2024-47834
CVE-2024-47835
CVE-2024-47774
CVE-2024-47778
CVE-2024-47777
CVE-2024-47776
CVE-2024-47775
CVE-2024-47615
CVE-2024-47613
CVE-2024-47607
CVE-2024-47541
CVE-2024-47538
CVE-2024-47603
CVE-2024-47601
CVE-2024-47602
CVE-2024-47600
CVE-2024-47540
CVE-2024-47599
CVE-2024-47596
CVE-2024-47606
CVE-2024-47546
CVE-2024-47597
CVE-2024-47544
CVE-2024-47545
CVE-2024-47543
CVE-2024-47542
CVE-2024-47539
CVE-2024-47598
CVE-2024-47537

@LeSuisse LeSuisse added 1.severity: security Issues which raise a security issue, or PRs that fix one backport staging-24.05 backport staging-24.11 Backport PR automatically labels Dec 13, 2024
@LeSuisse LeSuisse mentioned this pull request Dec 14, 2024
Merged
13 tasks
@LeSuisse
Copy link
Contributor

Bump to 1.24.10 was done in #365154

@vcunat
Copy link
Member

vcunat commented Dec 14, 2024

Superseded by #365154 I think.

@vcunat vcunat closed this Dec 14, 2024
vcunat
vcunat reviewed Dec 14, 2024
View reviewed changes
pkgs/development/python-modules/gst-python/default.nix
@@ -25,8 +25,8 @@ buildPythonPackage rec {
];

src = fetchurl {
url = "https://gstreamer.freedesktop.org/src/gst-python/${pname}-${version}.tar.xz";
hash = "sha256-bD7gKyDICobiQkWwYQLa4A4BdobydAdib0TcA6w8pTo=";
url = "https://gstreamer.freedesktop.org/src/gst-python/gst-python-${version}.tar.xz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't expect there was a reason to get rid of the ${pname}?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat left review comments

@bkchr bkchr Awaiting requested review from bkchr

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@ttuegel ttuegel Awaiting requested review from ttuegel

@wineee wineee Awaiting requested review from wineee

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 backport staging-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jwillikers @emilazy @wineee @LeSuisse @vcunat