Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.tornado: 6.4.1 -> 6.4.2 #358574

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Nov 23, 2024

Address CVE-2024-52804.

Release node: https://www.tornadoweb.org/en/stable/releases/v6.4.2.html

tornado_5 and tornado_5 currently don't build. I cannot test them even though the patch could be manually backported.

This security update requires a backport to Nixpkgs 24.11.

Cc: @FRidh @risicle @mweinelt

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ShamrockLee
Copy link
Contributor Author

This update turns out to cause a lot of rebuilds. Should a security update like this target master or staging?

@philiptaron
Copy link
Contributor

This update turns out to cause a lot of rebuilds. Should a security update like this target master or staging?

Lets just do staging

@ShamrockLee ShamrockLee force-pushed the tornado-update-security branch from eb74912 to 7d4a7ac Compare December 3, 2024 13:12
@ShamrockLee ShamrockLee changed the base branch from master to staging December 3, 2024 13:12
@ShamrockLee
Copy link
Contributor Author

nix-files-parseable-check complains error: path '/home/runner/work/nixpkgs/nixpkgs/pkgs/development/python-modules/uv/default.nix' does not exist, which seems unrelated to the changes in this PR. I'll rebase and see if the error persists.

@ShamrockLee ShamrockLee force-pushed the tornado-update-security branch from 7d4a7ac to 1f77429 Compare December 3, 2024 13:17
@ShamrockLee ShamrockLee added the backport staging-24.11 Backport PR automatically label Dec 3, 2024
@philiptaron
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 358574


x86_64-linux

✅ 2 packages built:
  • python3Packages.tornado
  • python3Packages.tornado.dist (python3Packages.tornado.dist.dist)

@ShamrockLee
Copy link
Contributor Author

@philiptaron How do you teach nixpkgs-review to avoid world-rebuilding?

@philiptaron
Copy link
Contributor

@philiptaron How do you teach nixpkgs-review to avoid world-rebuilding?

-p flag (which should show up in the posted command, but doesn't -- that's a bug!)

@philiptaron philiptaron merged commit 21ccdd8 into NixOS:staging Dec 3, 2024
17 of 18 checks passed
@nix-backports
Copy link

nix-backports bot commented Dec 3, 2024

Successfully created backport PR for staging-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants