-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zfs_2_1: remove #358811
Open
Mic92
wants to merge
1
commit into
NixOS:master
Choose a base branch
from
Mic92:zfs-21-removal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
zfs_2_1: remove #358811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: continuous integration
Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions
labels
Nov 24, 2024
nix-owners
bot
requested review from
infinisil,
LeSuisse,
mweinelt,
philiptaron,
RaitoBezarius and
risicle
November 24, 2024 21:37
13 tasks
Stray shell script? |
Mic92
force-pushed
the
zfs-21-removal
branch
from
November 24, 2024 21:52
453fa80
to
6eb30e3
Compare
github-actions
bot
removed
the
6.topic: continuous integration
Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions
label
Nov 24, 2024
Removed. |
philiptaron
approved these changes
Nov 24, 2024
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
labels
Nov 25, 2024
2.1 is probably not going anywhere and is going to be maintained in various
places.
Nonetheless, I do not plan to maintain ZFS anymore in nixpkgs. So I think
it's the right choice to deprecate it until someone wants to pick up that.
By the way, this is missing the removal of the series specific file.
Le jeu. 5 déc. 2024, 01:25, Adam C. Stephens ***@***.***> a
écrit :
… Yet, https://github.com/openzfs/zfs/releases/tag/zfs-2.1.16
—
Reply to this email directly, view it on GitHub
<#358811 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACMZRFVKCSCF723ZEQ5DP32D6MPDAVCNFSM6AAAAABSMVBO32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJYHAZDSMRWGA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
github-actions
bot
added
the
6.topic: continuous integration
Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions
label
Dec 9, 2024
adamcstephens
approved these changes
Dec 9, 2024
wegank
added
the
12.approvals: 2
This PR was reviewed and approved by two reputable people
label
Dec 10, 2024
Shouldn't we add an alias? |
@SuperSandro2000 an alias to what? |
@Mic92 this needs a rebase. I'm fine removing from unstable, but we'll keep supporting in 24.11. |
To a throw to have a cleaner deprecation. |
With the release of 2.3.0-rc, we know that 2.3.0 will be coming sometime soon. Per the [ZFS release policy][1], only the current and previous releases are expected to be supported, so 2.1.x will become unsupported. Unfortunately upstream does not have any specific timelines, so we do not know when it will become unsupported, but when it does we will likely backport the removal. As such, begin warning of imminent removal. [1]: https://github.com/openzfs/zfs/blob/6187b194349c5a728c9df8c6842f1866d5c9782a/RELEASES.md
Mic92
force-pushed
the
zfs-21-removal
branch
from
December 25, 2024 20:58
1a56781
to
cbc50da
Compare
wegank
removed
the
12.approvals: 2
This PR was reviewed and approved by two reputable people
label
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: continuous integration
Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: clean-up
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of #352402
waiting for https://github.com/openzfs/zfs/releases/tag/zfs-2.3.0
With the release of 2.3.0-rc, we know that 2.3.0 will be coming sometime soon. Per the ZFS release policy, only the current and previous releases are expected to be supported, so 2.1.x will become unsupported. Unfortunately upstream does not have any specific timelines, so we do not know when it will become unsupported, but when it does we will likely backport the removal. As such, begin warning of imminent removal.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.