-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump and rename siduck76-st > st-snazzy #360236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll have to squash your commits and put messages according to CONTRIBUTING.md/Commit conventions
52e6435
to
5ddfa68
Compare
5ddfa68
to
d70d1a7
Compare
d70d1a7
to
bca528c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do the maintainer addition to maintainer-list before the package change so our CI doesn't get confused.
installPhase = '' | ||
runHook preInstall | ||
|
||
TERMINFO=$out/share/terminfo make install PREFIX=$out | ||
|
||
runHook postInstall | ||
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't compile when I apply this change. I get the following error:
> mkdir -p /usr/local/bin
> mkdir: cannot create directory '/usr': Permission denied
> make: *** [Makefile:46: install] Error 1
I'm relatively new to Nix, so I don't quite understand why you made that suggestion and what the difference is between the two forms.
I have also tried this and got the same result:
env.TERMINFO = "${placeholder "out"}/share/terminfo make install PREFIX=${placeholder "out"}";
f638e7b
to
6b7471b
Compare
|
||
nativeBuildInputs = [ | ||
pkg-config | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nixfmt 'pkgs/by-name/st/st-snazzy/package.nix'
doesn't like this.
f81009f
to
e24bc48
Compare
e24bc48
to
dbe6cd8
Compare
The username has changed, and the name/description of the project.
Also the nixpkgs version was too old.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)I have made a flake, used the nixpkgs on my machine as input, and ran
nix build
to get the result.Add a 👍 reaction to pull requests you find important.