Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jellyseerr: 1.9.2 -> 2.1.0 #360844

Merged
merged 4 commits into from
Jan 4, 2025
Merged

jellyseerr: 1.9.2 -> 2.1.0 #360844

merged 4 commits into from
Jan 4, 2025

Conversation

coonce
Copy link
Contributor

@coonce coonce commented Dec 1, 2024

Updates jellyseerr to latest release (currently 2.1.0).
Also moves the pkg to by-name and changes updateScript to nix-update-script.

Release notes:
https://github.com/Fallenbagel/jellyseerr/releases/tag/v2.1.0

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

@camillemndn

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 1, 2024
@nix-owners
Copy link

nix-owners bot commented Dec 13, 2024

The PR's base branch is set to nixos-unstable, but 1962 commits from the master branch are included. Make sure you know the right base branch for your changes, then:

  • If the changes should go to the master branch, change the base branch to master
  • If the changes should go to the nixos-unstable branch, rebase your PR onto the merge base with the nixos-unstable branch:
    # git rebase --onto $(git merge-base upstream/nixos-unstable HEAD) $(git merge-base upstream/master HEAD)
    git rebase --onto a73246e2eef4c6ed172979932bc80e1404ba2d56 c99ef045eb3e4fd67eefaeb4d3fb7c54f6941f05
    git push --force-with-lease

@coonce coonce changed the base branch from nixos-unstable to master December 13, 2024 02:25
@github-actions github-actions bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 8.has: documentation This PR adds or changes documentation 8.has: changelog 6.topic: emacs Text editor 6.topic: policy discussion 6.topic: vim 6.topic: hardware 6.topic: pantheon The Pantheon desktop environment 6.topic: testing Tooling for automated testing of packages and modules 6.topic: cinnamon Desktop environment 6.topic: module system About "NixOS" module system internals 6.topic: jitsi 6.topic: systemd 6.topic: agda "A dependently typed programming language / interactive theorem prover" 6.topic: nim Nim programing language 6.topic: Lumina DE The Lumina Desktop Environment 6.topic: Enlightenment DE The Enlightenment Desktop Environment 6.topic: mate The MATE Desktop Environment 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: deepin Desktop environment and its components labels Dec 13, 2024
@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 18, 2024
@coonce coonce force-pushed the jellyseerr branch 2 times, most recently from 6b7cb02 to d4e5e68 Compare December 18, 2024 17:10
@coonce
Copy link
Contributor Author

coonce commented Dec 18, 2024

Sorry about all the force-pushes. I've not done many PRs, so bear with me! :) I think rebasing on nixpkgs/master caused the non-fast-forward...

Anyway, the suggestions sound great - it would be nice to be able to run via command line as well.

I added configDir and dataDir to match Jellyfin, but maybe Jellyseerr doesn't need both?

@wegank wegank removed 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 18, 2024
@ofborg ofborg bot requested a review from camillemndn December 19, 2024 05:52
@pizzapim
Copy link
Member

I would say adding dataDir does not make much sense because in the case of Jellyseerr, the config is equal to the data. I can confirm the package is working well, also with the --chdir!

installPhase = ''
runHook preInstall
mkdir -p $out/share
cp -r -t $out/share .next node_modules dist config package.json overseerr-api.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to copy the public directory as well. I see in my testing all static resources return 404s.

@coonce
Copy link
Contributor Author

coonce commented Dec 21, 2024

I don't have a great way to test with a browser on nixpkgs master at the moment, but the service startup looks good within a nixos/tests VM. Let me know if you see anything else. Thanks!

@pizzapim
Copy link
Member

Looks all good to me now

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 23, 2024
Copy link
Member

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I can't get the dependencies to build:

# nix log /nix/store/zqm81ca7spprlx41x1rkclf32xizq8g3-jellyseerr-pnpm-deps.drv

Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/ad25k5pnwp8h63x0b2dvq3fb9fyagkx1-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: installPhase
@nix { "action": "setPhase", "phase": "installPhase" }
 WARN  using --force I sure hope you know what you are doing
 ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)

Your Node version is incompatible with "/build/source".

Expected version: ^20.0.0
Got: v22.11.0

This is happening because the package's manifest has an engines.node field specified.
To fix this issue, install the required Node version.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 360844


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
❌ 1 package failed to build:
  • jellyseerr

@ofborg ofborg bot requested a review from camillemndn December 28, 2024 20:19
@coonce
Copy link
Contributor Author

coonce commented Dec 29, 2024

It looks like jellyseerr needs nodejs_20, which is strange because it has always built okay on my machine with just nodejs (nix-build -A jellyseerr). Maybe the nodejs pointer changed to nodejs_22 after the PR was opened?

@diogotcorreia
Copy link
Member

Fyi, Jellyseerr has updated to 2.2.3 https://github.com/Fallenbagel/jellyseerr/releases/tag/v2.2.3 (four releases in the past four days, but seems to have stabilized for now)
Should we update this PR as well?

Copy link
Member

@diogotcorreia diogotcorreia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested basic functionality through the resulting binary, working fine!

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 360844


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • jellyseerr

@wegank wegank merged commit 6decfba into NixOS:master Jan 4, 2025
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants