-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jellyseerr: 1.9.2 -> 2.1.0 #360844
jellyseerr: 1.9.2 -> 2.1.0 #360844
Conversation
The PR's base branch is set to nixos-unstable, but 1962 commits from the master branch are included. Make sure you know the right base branch for your changes, then:
|
6b7cb02
to
d4e5e68
Compare
Sorry about all the force-pushes. I've not done many PRs, so bear with me! :) I think rebasing on nixpkgs/master caused the non-fast-forward... Anyway, the suggestions sound great - it would be nice to be able to run via command line as well. I added |
I would say adding |
installPhase = '' | ||
runHook preInstall | ||
mkdir -p $out/share | ||
cp -r -t $out/share .next node_modules dist config package.json overseerr-api.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have to copy the public
directory as well. I see in my testing all static resources return 404s.
I don't have a great way to test with a browser on nixpkgs master at the moment, but the service startup looks good within a nixos/tests VM. Let me know if you see anything else. Thanks! |
Looks all good to me now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I can't get the dependencies to build:
# nix log /nix/store/zqm81ca7spprlx41x1rkclf32xizq8g3-jellyseerr-pnpm-deps.drv
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/ad25k5pnwp8h63x0b2dvq3fb9fyagkx1-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: installPhase
@nix { "action": "setPhase", "phase": "installPhase" }
WARN using --force I sure hope you know what you are doing
ERR_PNPM_UNSUPPORTED_ENGINE Unsupported environment (bad pnpm and/or Node.js version)
Your Node version is incompatible with "/build/source".
Expected version: ^20.0.0
Got: v22.11.0
This is happening because the package's manifest has an engines.node field specified.
To fix this issue, install the required Node version.
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 360844
x86_64-linux
⏩ 2 packages blacklisted:
- nixos-install-tools
- tests.nixos-functions.nixos-test
❌ 1 package failed to build:
- jellyseerr
It looks like |
Fyi, Jellyseerr has updated to 2.2.3 https://github.com/Fallenbagel/jellyseerr/releases/tag/v2.2.3 (four releases in the past four days, but seems to have stabilized for now) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested basic functionality through the resulting binary, working fine!
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 360844
x86_64-linux
⏩ 2 packages blacklisted:
- nixos-install-tools
- tests.nixos-functions.nixos-test
✅ 1 package built:
- jellyseerr
Updates jellyseerr to latest release (currently 2.1.0).
Also moves the pkg to by-name and changes updateScript to nix-update-script.
Release notes:
https://github.com/Fallenbagel/jellyseerr/releases/tag/v2.1.0
@camillemndn