Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopass: 1.15.14 -> 1.15.15 with added updateScript #360950

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

kachick
Copy link
Member

@kachick kachick commented Dec 2, 2024

Release: https://github.com/gopasspw/gopass/releases/tag/v1.15.15

Related projects are already updated #358760, #358876
And nixpkgs-update skipped because of the title matched with one of above PRs. https://nixpkgs-update-logs.nix-community.org/gopass/2024-11-25.log

gopass 1.15.14 -> 1.15.15 https://github.com/gopasspw/gopass/releases
attrpath: gopass
Checking auto update branch...
No auto update branch exists
There might already be an open PR for this update:
- gopass-jsonapi: 1.15.14 -> 1.15.15
  URL "https://api.github.com/repos/NixOS/nixpkgs/issues/358760"

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kachick

This comment was marked as resolved.

@kachick kachick marked this pull request as draft December 2, 2024 03:21
@kachick
Copy link
Member Author

kachick commented Dec 2, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 360950


x86_64-linux

✅ 4 packages built:
  • git-credential-gopass
  • gopass
  • gopass-hibp
  • gopass-summon-provider

x86_64-darwin

✅ 4 packages built:
  • git-credential-gopass
  • gopass
  • gopass-hibp
  • gopass-summon-provider

aarch64-darwin

✅ 4 packages built:
  • git-credential-gopass
  • gopass
  • gopass-hibp
  • gopass-summon-provider

@kachick kachick marked this pull request as ready for review December 2, 2024 04:00
@kachick kachick requested review from rvolosatovs and sikmir December 2, 2024 04:02
@sikmir
Copy link
Member

sikmir commented Dec 2, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 360950


x86_64-darwin

✅ 4 packages built:
  • git-credential-gopass
  • gopass
  • gopass-hibp
  • gopass-summon-provider

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 3, 2024
@kachick
Copy link
Member Author

kachick commented Dec 4, 2024

Failed ofborg-eval-lib-tests — nix-build --arg pkgs import ./. {} ./lib/tests/release.nix from #354738, I'll rebase to avoid it.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 4, 2024
@ofborg ofborg bot requested a review from sikmir December 4, 2024 16:21
@sikmir sikmir merged commit 0d7ab66 into NixOS:master Dec 4, 2024
33 of 34 checks passed
@kachick
Copy link
Member Author

kachick commented Dec 5, 2024

Thanks!

@kachick kachick deleted the update-gopass branch December 5, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants