Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stripe-cli: 1.21.10 -> 1.22.0 #361049

Merged
merged 1 commit into from
Dec 15, 2024
Merged

stripe-cli: 1.21.10 -> 1.22.0 #361049

merged 1 commit into from
Dec 15, 2024

Conversation

afh
Copy link
Member

@afh afh commented Dec 2, 2024

Release notes: https://github.com/stripe/stripe-cli/releases

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@afh
Copy link
Member Author

afh commented Dec 2, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 361049


x86_64-linux

✅ 1 package built:
  • stripe-cli

@afh
Copy link
Member Author

afh commented Dec 6, 2024

@ofborg: eval

Copy link
Member

@06kellyjac 06kellyjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


src = fetchFromGitHub {
owner = "stripe";
repo = pname;
rev = "v${version}";
hash = "sha256-L2ydkrm2foSIh67LsMYNvV53Hdj9TdV7C4tKeHe+AK0=";
hash = "sha256-h5Q9+WoMJ5swmyL4GIiWZ9HDnr/w23iBVtp4EQ1yYn0=";
};
vendorHash = "sha256-TuxYJ3u4/5PJYRoRgom+M1au9XerZ+vj9X3jUWTPM58=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm amazed the dependencies haven't been updated for 6 months...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As am I 🙂

I took the liberty of adding a minor changes that removes the use of pname for the repo attribute.

@06kellyjac 06kellyjac added the backport release-24.11 Backport PR automatically label Dec 11, 2024
@afh afh added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Dec 12, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2145

@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Dec 12, 2024
@afh afh added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 13, 2024
@thiagokokada
Copy link
Contributor

@ofborg eval

@ofborg ofborg bot requested review from kashw2 and 06kellyjac December 14, 2024 15:18
@afh afh removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 14, 2024
@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Dec 15, 2024
@RaghavSood RaghavSood merged commit e3e9e32 into NixOS:master Dec 15, 2024
42 of 43 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 15, 2024

Successfully created backport PR for release-24.11:

@afh afh deleted the update-stripe branch December 15, 2024 17:36
@afh
Copy link
Member Author

afh commented Dec 15, 2024

Thanks for merging this, @RaghavSood, this is very helpful 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants