Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/ananicy: fix eval when hardened kernel is used with ananicy-cpp #361172

Merged
merged 1 commit into from
Dec 3, 2024
Merged

nixos/ananicy: fix eval when hardened kernel is used with ananicy-cpp #361172

merged 1 commit into from
Dec 3, 2024
+1 −1

Conversation

JohnRTitor
Copy link
Contributor

@JohnRTitor JohnRTitor commented Dec 2, 2024 •
edited
Loading

Fixes #360957

Things done

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 2, 2024
@JohnRTitor
Copy link
Contributor Author

@MrQubo JohnRTitor/nix-conf@d5b1cfa you can test it like this . I have seen your tracefs solution (but I should probably ask @Artturin as I don't know much about it). I would prefer getting this fix merged first.

@JohnRTitor JohnRTitor requested a review from Artturin December 2, 2024 18:57
@JohnRTitor
Copy link
Contributor Author

@ofborg eval

@JohnRTitor
Copy link
Contributor Author

That test is broken because of #354738, which already got reverted

@JohnRTitor JohnRTitor merged commit 2bedc78 into NixOS:master Dec 3, 2024
28 of 30 checks passed
@JohnRTitor JohnRTitor deleted the ananicy-module branch December 3, 2024 11:44
@MrQubo
Copy link
Contributor

MrQubo commented Dec 3, 2024 •
edited
Loading

@MrQubo JohnRTitor/nix-conf@d5b1cfa you can test it like this . I have seen your tracefs solution (but I should probably ask @Artturin as I don't know much about it). I would prefer getting this fix merged first.

I'm using channels though. I just replaced whole nixos channel and rebuilt my own configuration.

But thanks for the idea of just importing one module, as replacing whole channel sometimes breaks other parts of configuration (especially because my configuration is for stable channel).

This was referenced Dec 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artturin Artturin Awaiting requested review from Artturin

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixos/ananicy: impossible to use ananicy-cpp with bpf enabled on hardened kernel
2 participants
@JohnRTitor @MrQubo