-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodePackages.ganache: drop #361285
Merged
Merged
nodePackages.ganache: drop #361285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrox0
force-pushed
the
node-drop/ganache
branch
from
December 3, 2024 01:48
b665235
to
466799c
Compare
pyrox0
force-pushed
the
node-drop/ganache
branch
from
December 3, 2024 06:09
466799c
to
b137059
Compare
13 tasks
philipmw
approved these changes
Dec 3, 2024
pyrox0
force-pushed
the
node-drop/ganache
branch
from
December 4, 2024 01:01
b137059
to
3909428
Compare
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: documentation
This PR adds or changes documentation
8.has: changelog
labels
Dec 4, 2024
@ofborg build lightouse |
getchoo
approved these changes
Dec 4, 2024
getchoo
added
12.approvals: 1
This PR was reviewed and approved by one reputable person
12.approvals: 2
This PR was reviewed and approved by two reputable people
and removed
12.approvals: 2
This PR was reviewed and approved by two reputable people
labels
Dec 4, 2024
wegank
added
12.approvals: 2
This PR was reviewed and approved by two reputable people
and removed
12.approvals: 1
This PR was reviewed and approved by one reputable person
labels
Dec 4, 2024
philipmw
approved these changes
Dec 4, 2024
pyrox0
added
12.approvals: 3+
This PR was reviewed and approved by three or more reputable people
12.approved-by: package-maintainer
This PR was reviewed and approved by a maintainer listed in the package
and removed
12.approvals: 2
This PR was reviewed and approved by two reputable people
labels
Dec 5, 2024
wegank
added
12.approvals: 2
This PR was reviewed and approved by two reputable people
and removed
12.approvals: 3+
This PR was reviewed and approved by three or more reputable people
labels
Dec 5, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: nodejs
8.has: changelog
8.has: documentation
This PR adds or changes documentation
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
12.approvals: 2
This PR was reviewed and approved by two reputable people
12.approved-by: package-maintainer
This PR was reviewed and approved by a maintainer listed in the package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lighthouse
does not use this package anymore, its test suite works properly after removing this.the package has been deprecated per upstream: trufflesuite/ganache#4536
part of #229475
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.