Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nezha: 0.20.3 -> 1.6.3; nezha-agent: 0.20.5 -> 1.6.0; nixos/nezha-agent: refactor #361515

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Moraxyc
Copy link
Contributor

@Moraxyc Moraxyc commented Dec 3, 2024

BREAKING CHANGE: Incompatible Configuration Changes

  • The upgrade includes significant architectural changes, resulting in a complete incompatibility with previous configurations.
  • Users will need to reconfigure their setups as the old configuration is no longer supported.
  • Please review the updated documentation for the new configuration format and features.
    Docs: https://nezha.wiki

Due to changes in the communication protocol between the client and server, the agent‘s upgrade also be included in this PR.

Must be merged after #374097(Done)
Must be merged after #364131 and #364145(Done)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 3, 2024
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 4, 2024
@github-actions github-actions bot added the 8.has: module (update) This PR changes an existing module in `nixos/` label Dec 5, 2024
@Moraxyc Moraxyc changed the title nezha: 0.20.3 -> 1.0.17 nezha: 0.20.3 -> 1.0.21; nezha-agent: 0.20.5 -> 1.0.4; nixos/nezha: init; nixos/nezha-agent: refactor Dec 5, 2024
@Moraxyc Moraxyc marked this pull request as ready for review December 5, 2024 06:10
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Dec 7, 2024
@Moraxyc Moraxyc force-pushed the update-nezha branch 2 times, most recently from 00fbf56 to 0b92d7d Compare December 7, 2024 10:55
@Moraxyc Moraxyc marked this pull request as draft December 8, 2024 05:34
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Dec 8, 2024
@Moraxyc Moraxyc changed the title nezha: 0.20.3 -> 1.0.21; nezha-agent: 0.20.5 -> 1.0.4; nixos/nezha: init; nixos/nezha-agent: refactor nezha: 0.20.3 -> 1.1.4; nezha-agent: 0.20.5 -> 1.0.6; nixos/nezha-agent: refactor Dec 11, 2024
@Moraxyc Moraxyc removed 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Dec 11, 2024
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 12, 2024
@Moraxyc Moraxyc mentioned this pull request Dec 13, 2024
13 tasks
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2025
@Moraxyc Moraxyc changed the title nezha: 0.20.3 -> 1.1.4; nezha-agent: 0.20.5 -> 1.0.6; nixos/nezha-agent: refactor nezha: 0.20.3 -> 1.5.6; nezha-agent: 0.20.5 -> 1.5.2; nixos/nezha-agent: refactor Jan 4, 2025
@Moraxyc Moraxyc removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2025
@Moraxyc Moraxyc marked this pull request as ready for review January 4, 2025 09:26
@wolfgangwalther
Copy link
Contributor

#370824 is merged, can you rebase on latest master to confirm that Eval / Tag will run correctly?

Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a review, just spotted this randomly.

pkgs/by-name/ne/nezha/package.nix Outdated Show resolved Hide resolved
@Moraxyc
Copy link
Contributor Author

Moraxyc commented Jan 4, 2025

#370824 is merged, can you rebase on latest master to confirm that Eval / Tag will run correctly?

https://github.com/NixOS/nixpkgs/actions/runs/12610251767/job/35144742184?pr=361515

Thanks! It works good now.

@L-Trump
Copy link
Contributor

L-Trump commented Jan 14, 2025

nezha v1.5.13 and nezha-agent v1.5.6 has been released
https://github.com/nezhahq/nezha/releases/tag/v1.5.13
https://github.com/nezhahq/agent/releases/tag/v1.5.6
:D

@Moraxyc
Copy link
Contributor Author

Moraxyc commented Jan 14, 2025

nezha v1.5.13 and nezha-agent v1.5.6 has been released https://github.com/nezhahq/nezha/releases/tag/v1.5.13 https://github.com/nezhahq/agent/releases/tag/v1.5.6 :D

I'll bump these and themes later.

@Moraxyc Moraxyc changed the title nezha: 0.20.3 -> 1.5.6; nezha-agent: 0.20.5 -> 1.5.2; nixos/nezha-agent: refactor nezha: 0.20.3 -> 1.5.13; nezha-agent: 0.20.5 -> 1.5.6; nixos/nezha-agent: refactor Jan 15, 2025
@Moraxyc
Copy link
Contributor Author

Moraxyc commented Jan 15, 2025

themes: #374097

@L-Trump
Copy link
Contributor

L-Trump commented Jan 17, 2025

Tested on linux-x86_64 hosts, everything works well.

@L-Trump L-Trump added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 17, 2025
@Moraxyc Moraxyc changed the title nezha: 0.20.3 -> 1.5.13; nezha-agent: 0.20.5 -> 1.5.6; nixos/nezha-agent: refactor nezha: 0.20.3 -> 1.6.3; nezha-agent: 0.20.5 -> 1.6.0; nixos/nezha-agent: refactor Jan 22, 2025
@Moraxyc

This comment was marked as outdated.

BREAKING CHANGE: Incompatible Configuration Changes
- The upgrade includes significant architectural changes, resulting in a complete incompatibility with previous configurations.
- Users will need to reconfigure their setups as the old configuration is no longer supported.
- Please review the updated documentation for the new configuration format and features.

Docs: https://nezha.wiki
Diff: nezhahq/agent@refs/tags/v0.20.5...v1.6.0

BREAKING CHANGE: Incompatible Configuration Changes
- The upgrade includes significant architectural changes, resulting in a complete incompatibility with previous configurations.
- Users will need to reconfigure their setups as the old configuration is no longer supported.
- Please review the updated documentation for the new configuration format and features.

Docs: https://nezha.wiki
@Moraxyc
Copy link
Contributor Author

Moraxyc commented Jan 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 361515


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 2 packages built:
  • nezha
  • nezha-agent

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 2 packages built:
  • nezha
  • nezha-agent

x86_64-darwin

✅ 2 packages built:
  • nezha
  • nezha-agent

aarch64-darwin

✅ 2 packages built:
  • nezha
  • nezha-agent

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants