Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

houdini: 20.5.370 -> 20.5.445 #361799

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

pedohorse
Copy link
Contributor

@pedohorse pedohorse commented Dec 4, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 4, 2024
@pedohorse
Copy link
Contributor Author

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • houdini

@pedohorse pedohorse force-pushed the houdini_20-5-370_20-5-410 branch from ff52f70 to 5abe379 Compare December 22, 2024 19:55
@pedohorse pedohorse changed the title houdini: 20.5.370 -> 20.5.410 houdini: 20.5.370 -> 20.5.445 Dec 22, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4992

@thiagokokada
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 361799

@thiagokokada thiagokokada merged commit db84f5b into NixOS:master Dec 29, 2024
44 checks passed
@wrvsrx
Copy link
Contributor

wrvsrx commented Jan 4, 2025

Why make houdini-runtime as a fixed-output derivation?

@pedohorse
Copy link
Contributor Author

pedohorse commented Jan 4, 2025

why fixed-output:
the contents of houdini-runtime is result of self-extraction of installer provided by the vendor. It does not depend on anything except that installer.
When it was not a fixed-output derivation - every time you updated your system you needed to rebuild houdini-runtime from original installer archive, and that archive was being garbage collected all the time - so that all caused a bunch of inconveniences, and took way too much space, since the installer archive is 2+ GB, and houdini-runtime is similarly 2+ GB, and you don't want multiples of them for each system rebuild, especially since they are the same.

but are you experiencing any problems with it being fixed-output now?

@wrvsrx
Copy link
Contributor

wrvsrx commented Jan 4, 2025

I need an older version of houdini. Now I need to set outputHash = null to overrideAttrs.

It doesn't make much inconviniences, but it feels strange to set outputHash for a local build result.

@wrvsrx
Copy link
Contributor

wrvsrx commented Jan 4, 2025

Besides, is houdini running well on your side? I found houdini can't run after #363168. Would you like to check my fix #370461

@pedohorse
Copy link
Contributor Author

pedohorse commented Jan 4, 2025

oh my, that's no good.
how come i was not notified about that PR, even though i'm set as maintainer on houdini package??

also for older versions - I'm maintaining this flake, it makes things very easy: https://github.com/pedohorse/houdini-nix
I myself am using only that, so I didn't notice the breakage in nixpkgs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants