Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resources: 1.6.0 -> 1.7.0 #362143

Merged
merged 1 commit into from
Dec 6, 2024
Merged

resources: 1.6.0 -> 1.7.0 #362143

merged 1 commit into from
Dec 6, 2024

Conversation

Saeverix
Copy link
Contributor

@Saeverix Saeverix commented Dec 5, 2024 •
edited
Loading

Diff: nokyan/resources@refs/tags/v1.6.0...v1.7.0

Changelog: https://github.com/nokyan/resources/releases/tag/v1.7.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Saeverix
Copy link
Contributor Author

Saeverix commented Dec 5, 2024 •
edited
Loading

Hi everyone. This is my first contribution to nixpkgs, and I used nix-upgrade to upgrade the package and create the commit message.

If something is wrong, please let me know. Also I am curious if the update will also be backported to the current 24.11 repository automatically, can someone confirm that?

@Saeverix Saeverix changed the title resources: 1.7.0 -> 1.7.0 resources: 1.6.0 -> 1.7.0 Dec 5, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 5, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 5, 2024
Aleksanaa
Aleksanaa approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on x86_64-linux.

@Aleksanaa
Copy link
Member

@ofborg build resources

@Aleksanaa Aleksanaa merged commit c2dc40e into NixOS:master Dec 6, 2024
27 of 30 checks passed
@Aleksanaa Aleksanaa added the backport release-24.11 Backport PR automatically label Dec 6, 2024
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 6, 2024

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 6, 2024
Merged
1 task
@Saeverix Saeverix deleted the update-resources branch December 6, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle! backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saeverix @Aleksanaa @NixOSInfra