Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.11]: k9s: 0.32.5 -> 0.32.7 #362456

Merged

Conversation

Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Dec 6, 2024

#356238
#360993

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@kachick kachick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • As far as I know, we have no reason to block merging in NixOS 24.11
  • Especially 0.32.6 have a GHSA-v23v-6jw2-98fq fixes

LGTM 👍

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 6, 2024
getchoo
getchoo previously requested changes Dec 8, 2024
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing on x86_64-darwin. This doesn't appear to be happening on master

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 16, 2024
@Scrumplex
Copy link
Member Author

Tests are failing on x86_64-darwin. This doesn't appear to be happening on master

Builds fine on my builder.

@Scrumplex
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 362456


x86_64-linux

✅ 1 package built:
  • k9s

x86_64-darwin

✅ 1 package built:
  • k9s

aarch64-darwin

✅ 1 package built:
  • k9s

@Scrumplex Scrumplex requested a review from getchoo December 17, 2024 19:02
@getchoo
Copy link
Member

getchoo commented Dec 19, 2024

@ofborg build k9s k9s.passthru.tests

@wolfgangwalther wolfgangwalther dismissed getchoo’s stale review December 22, 2024 12:50

k9s, k9s.passthru.tests on x86_64-darwin — Success

@wolfgangwalther wolfgangwalther merged commit 2b838a4 into NixOS:release-24.11 Dec 22, 2024
78 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants