-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.11]: k9s: 0.32.5 -> 0.32.7 #362456
[24.11]: k9s: 0.32.5 -> 0.32.7 #362456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- As far as I know, we have no reason to block merging in NixOS 24.11
- Especially 0.32.6 have a GHSA-v23v-6jw2-98fq fixes
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing on x86_64-darwin. This doesn't appear to be happening on master
Builds fine on my builder. |
|
@ofborg build k9s k9s.passthru.tests |
k9s, k9s.passthru.tests on x86_64-darwin — Success
#356238
#360993
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.