-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.pbr: fix python 3.12 compatibility; python312Packages.openstackdocstheme: allow for python 3.12; openstack for python 3.12 #362467
Conversation
9bae2ee
to
55a30bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a fix for jenkins-job-builder that isn't a mass-rebuild (#363535), so it can be distributed to users more quickly (and also fixes jenkins-job-builder runtime deps). Please rebase on top of that?
The changes done in that PR fix the issue but in the wrong package and there are still some parts in pbr which then would be wrong. I won't accept them for openstackdocstheme in the long run and I really don't want to play the rebase game. Also the other dependency change is not quite correct. |
Successfully created backport PR for |
@SuperSandro2000: I'm adding the backport label because we need to fix jenkins-job-builder on the NixOS release. I hope this PR was made with backporting in mind. |
@@ -79,6 +85,6 @@ python3Packages.buildPythonApplication rec { | |||
mainProgram = "reno"; | |||
homepage = "https://docs.openstack.org/reno/latest"; | |||
license = licenses.asl20; | |||
maintainers = teams.openstack.members ++ (with maintainers; [ drewrisinger guillaumekoenig ]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the maintainers removed? IMHO, removal of maintainers requires more rationale than saying "misc cleanup" in the commit message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have made it more explicit, yes. They didn't update the package in 4 years https://github.com/openstack/reno/tags and now it got absorbed into the general Openstack maintenance team https://github.com/NixOS/nixpkgs/commits/master/pkgs/development/tools/reno
I didn't make the PR with backporting in mind but I don't think there are breaking changes and except the cleanups this is the minimal required change to fix the packages for python 3.12 unless we want to take incorrect shortcuts. The general bump of all openstack tools will not be back ported though. |
Build python312Packages.jenkins-job-builder, python312Packages.jenkins-job-builder, python312Packages.python-cinderclient, python312Packages.python-openstack-client, python312Packages.python-openstackclient
I forgot to mention that the reno change is required to fix python-cinderclient on python 3.12 otherwise it cannot be imported anymore. Not sure why exactly but since it was a none python package, probably some impurities where fixed somewhere.
Closes #362054
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.