Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.pbr: fix python 3.12 compatibility; python312Packages.openstackdocstheme: allow for python 3.12; openstack for python 3.12 #362467

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 6, 2024

Build python312Packages.jenkins-job-builder, python312Packages.jenkins-job-builder, python312Packages.python-cinderclient, python312Packages.python-openstack-client, python312Packages.python-openstackclient

I forgot to mention that the reno change is required to fix python-cinderclient on python 3.12 otherwise it cannot be imported anymore. Not sure why exactly but since it was a none python package, probably some impurities where fixed somewhere.

Closes #362054

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 8, 2024
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a fix for jenkins-job-builder that isn't a mass-rebuild (#363535), so it can be distributed to users more quickly (and also fixes jenkins-job-builder runtime deps). Please rebase on top of that?

@SuperSandro2000
Copy link
Member Author

The changes done in that PR fix the issue but in the wrong package and there are still some parts in pbr which then would be wrong. I won't accept them for openstackdocstheme in the long run and I really don't want to play the rebase game. Also the other dependency change is not quite correct.

@SuperSandro2000 SuperSandro2000 merged commit b320044 into NixOS:staging Dec 9, 2024
53 of 54 checks passed
@SuperSandro2000 SuperSandro2000 deleted the openstack-312 branch December 9, 2024 17:41
@bjornfor bjornfor added the backport staging-24.11 Backport PR automatically label Dec 9, 2024
@bjornfor
Copy link
Contributor

bjornfor commented Dec 9, 2024

@SuperSandro2000: I'm adding the backport label because we need to fix jenkins-job-builder on the NixOS release. I hope this PR was made with backporting in mind.

@@ -79,6 +85,6 @@ python3Packages.buildPythonApplication rec {
mainProgram = "reno";
homepage = "https://docs.openstack.org/reno/latest";
license = licenses.asl20;
maintainers = teams.openstack.members ++ (with maintainers; [ drewrisinger guillaumekoenig ]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the maintainers removed? IMHO, removal of maintainers requires more rationale than saying "misc cleanup" in the commit message.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have made it more explicit, yes. They didn't update the package in 4 years https://github.com/openstack/reno/tags and now it got absorbed into the general Openstack maintenance team https://github.com/NixOS/nixpkgs/commits/master/pkgs/development/tools/reno

@SuperSandro2000
Copy link
Member Author

I didn't make the PR with backporting in mind but I don't think there are breaking changes and except the cleanups this is the minimal required change to fix the packages for python 3.12 unless we want to take incorrect shortcuts.

The general bump of all openstack tools will not be back ported though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport staging-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: python312Packages.jenkins-job-builder
4 participants