Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nebula: 1.9.4 -> 1.9.5 #362508

Merged
merged 1 commit into from
Dec 10, 2024
Merged

nebula: 1.9.4 -> 1.9.5 #362508

merged 1 commit into from
Dec 10, 2024

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Dec 6, 2024 •
edited
Loading

https://github.com/slackhq/nebula/releases/tag/v1.9.5

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from Br1ght0ne and numinit December 7, 2024 12:16
@numinit
Copy link
Contributor

numinit commented Dec 9, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 362508

x86_64-linux

✅ 1 package built:
  • nebula

@numinit
Copy link
Contributor

numinit commented Dec 9, 2024

NixOS tests succeed with nix-build -A nixosTests.nebula.

This fixes some issues with relaying and is otherwise a fairly minor update, so marking as a backport candidate.

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 9, 2024
@getchoo getchoo added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 10, 2024
@getchoo getchoo merged commit daba675 into NixOS:master Dec 10, 2024
55 of 56 checks passed
nixpkgs-ci bot pushed a commit that referenced this pull request Dec 10, 2024
@bbigras @github-actions
nebula: 1.9.4 -> 1.9.5 (#362508)
e5ca0d3 
(cherry picked from commit daba675)
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 10, 2024

Successfully created backport PR for release-24.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 10, 2024
Merged
1 task
nixpkgs-ci bot pushed a commit that referenced this pull request Dec 10, 2024
@bbigras @github-actions
nebula: 1.9.4 -> 1.9.5 (#362508)
6b4bf6e 
(cherry picked from commit daba675)
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 10, 2024

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 10, 2024
Merged
1 task
@bbigras bbigras deleted the push-ytxollyookkn branch December 10, 2024 06:16
@bbigras
Copy link
Contributor Author

bbigras commented Dec 10, 2024

Thanks!

getchoo pushed a commit that referenced this pull request Dec 10, 2024
@nixpkgs-ci @bbigras
[Backport release-24.11] nebula: 1.9.4 -> 1.9.5 (#363821)
343b385 
nebula: 1.9.4 -> 1.9.5 (#362508)

(cherry picked from commit daba675)

Co-authored-by: Bruno Bigras <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo approved these changes

@numinit numinit numinit approved these changes

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bbigras @numinit @getchoo @wegank